Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit 993d2c5

Browse files
committed
test: refator and added comment for clarity about it
1 parent e51f5c4 commit 993d2c5

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

‎src/__tests__/utils/runForRenderers.ts

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,10 @@ function requireRenderer<TRendererType extends ReactHooksRenderer = ReactHooksRe
3232
return require(requirePath) as TRendererType
3333
}
3434

35-
functionhydratedServerRenderer(pure: boolean): ReactHooksRenderer{
36-
const{ renderHook, ...otherImports}=requireRenderer<ReactHooksServerRenderer>(
37-
pure ? 'server/pure' : 'server'
38-
)
35+
// This render turns the `server` renderer into a client renderer as many of the tests only
36+
// require hydration after the hook is renderer to be able to be reused for all the renderers
37+
functionhydratedServerRenderer(baseRenderer: 'server'|'server/pure'): ReactHooksRenderer{
38+
const{ renderHook, ...otherImports}=requireRenderer<ReactHooksServerRenderer>(baseRenderer)
3939

4040
return {
4141
renderHook<TProps, TResult>(
@@ -61,8 +61,8 @@ const rendererResolvers = {
6161
'dom/pure': () => requireRenderer('default/pure'),
6262
'native/pure': () => requireRenderer('default/pure'),
6363
'server/pure': () => requireRenderer<ReactHooksServerRenderer>('server/pure'),
64-
'server/hydrated': () => hydratedServerRenderer(false),
65-
'server/hydrated/pure': () => hydratedServerRenderer(true)
64+
'server/hydrated': () => hydratedServerRenderer('server'),
65+
'server/hydrated/pure': () => hydratedServerRenderer('server/pure')
6666
}
6767

6868
global.runForRenderers = function runForRenderers<TRenderer extends Renderer>(
@@ -77,6 +77,7 @@ global.runForLazyRenderers = function runForLazyRenderers<TRenderer extends Rend
7777
fn: (getRenderer: () => InferredRenderer<TRenderer>, rendererName: Renderer) => void
7878
): void {
7979
renderers.forEach((renderer) => {
80+
// eslint-disable-next-line jest/valid-title
8081
describe(renderer, () => {
8182
fn(() => rendererResolvers[renderer]() as InferredRenderer<TRenderer>, renderer)
8283
})

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /