Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit 238a9ea

Browse files
authored
chore(ci): clean up validate scripts to remove duplication (#664)
1 parent d946e3c commit 238a9ea

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

‎.github/workflows/validate.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,8 @@ jobs:
3838
env:
3939
HUSKY_SKIP_INSTALL: true
4040

41-
- name: Use React version
42-
run: npm install --save-dev react@"${{ matrix.react }}" react-dom@"${{ matrix.react }}" react-test-renderer@"${{ matrix.react }}"
41+
- name: ⚛️ Use React version
42+
run: REACT_VERSION=${{ matrix.react }} npm run install:react
4343

4444
- name: ▶️ Run validate script
4545
run: npm run validate

‎package.json

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,10 @@
4343
"docs:dev": "docz dev",
4444
"docs:build": "docz build",
4545
"contributors:add": "all-contributors add",
46-
"install:react-16-9": "npm install --no-save react@16.9.0 react-dom@16.9.0 react-test-renderer@16.9.0",
47-
"install:react-16": "npm install --no-save react@^16 react-dom@^16 react-test-renderer@^16",
48-
"install:react-17": "npm install --no-save react@^17 react-dom@^17 react-test-renderer@^17"
46+
"install:react": "npm install --no-save react@${REACT_VERSION:-latest} react-dom@${REACT_VERSION:-latest} react-test-renderer@${REACT_VERSION:-latest}",
47+
"install:react-16.9.0": "cross-env REACT_VERSION=16.9.0 npm run install:react",
48+
"install:react-16": "cross-env REACT_VERSION=^16 npm run install:react",
49+
"install:react-17": "cross-env REACT_VERSION=^17 npm run install:react"
4950
},
5051
"dependencies": {
5152
"@babel/runtime": "^7.12.5",
@@ -59,6 +60,7 @@
5960
"@typescript-eslint/parser": "4.28.5",
6061
"all-contributors-cli": "6.20.0",
6162
"codecov": "3.8.3",
63+
"cross-env": "^7.0.3",
6264
"docz": "2.3.1",
6365
"docz-theme-default": "1.2.0",
6466
"docz-utils": "2.3.0",

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /