Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Aug 6, 2025. It is now read-only.

Commit 4b7eb6e

Browse files
committed
ci(actions): remove Node 12 and add Node 18 to the matrix
Playwright dropped support for Node 12 in a non-breaking release, but it's leaving LTS soon anyways.
1 parent 401f2ce commit 4b7eb6e

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

‎.github/workflows/build.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
runs-on: ubuntu-latest
1818
strategy:
1919
matrix:
20-
node: ['12', '14', '16']
20+
node: ['14', '16', '18']
2121
# TODO: technically we still support down to 1.12 but `locator.waitFor`
2222
# was introduced in 1.16 so anything earlier blows up type-checking.
2323
# This minimum will be bumped in the next breaking release that will be
@@ -68,7 +68,7 @@ jobs:
6868
npm why @playwright/test
6969
npm run test:legacy
7070
71-
# Only release on Node 14
71+
# Only release on Node 16
7272

7373
- name: Upload Coverage / Release / Playwright
7474
run: npm run ci-after-success
@@ -99,13 +99,13 @@ jobs:
9999
run: echo ::set-output name=branch::${GITHUB_REF#refs/*/}
100100

101101
- name: Release / Playwright Test (latest)
102-
if: ${{ matrix.node == '14' && matrix.playwright == 'latest' && steps.did-release.outputs.released == 'true' && steps.branch.outputs.branch == 'main' }}
102+
if: ${{ matrix.node == '16' && matrix.playwright == 'latest' && steps.did-release.outputs.released == 'true' && steps.branch.outputs.branch == 'main' }}
103103
run: |
104104
npm run prepare:playwright-test
105105
npm publish --access=public
106106
107107
- name: Release / Playwright Test (pre-release)
108-
if: ${{ matrix.node == '14' && matrix.playwright == 'latest' && steps.did-release.outputs.released == 'true' && steps.branch.outputs.branch != 'main' }}
108+
if: ${{ matrix.node == '16' && matrix.playwright == 'latest' && steps.did-release.outputs.released == 'true' && steps.branch.outputs.branch != 'main' }}
109109
run: |
110110
npm run prepare:playwright-test
111111
npm publish --access=public --tag=${{ steps.branch.outputs.branch }}

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /