Commit 54ee4ae

authored

fix(await-async-event): prevent adding async/await in forEach loops (#1075)

Fixes #843

1 parent 1477f21 commit 54ee4aeCopy full SHA for 54ee4ae

File tree

+27

-0

lines changed

+27

-0

lines changed

Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,7 @@ import { createTestingLibraryRule } from '../create-testing-library-rule';`
`4`	`4`	`import {`
`5`	`5`	`findClosestCallExpressionNode,`
`6`	`6`	`findClosestFunctionExpressionNode,`
	`7`	`+ getDeepestIdentifierNode,`
`7`	`8`	`getFunctionName,`
`8`	`9`	`getInnermostReturningFunction,`
`9`	`10`	`getVariableReferences,`
`@@ -250,6 +251,13 @@ export default createTestingLibraryRule<Options, MessageIds>({`
`250`	`251`	`findClosestFunctionExpressionNode(node);`
`251`	`252`
`252`	`253`	`if (functionExpression) {`
	`254`	`+ const deepestCalleeIdentifier = getDeepestIdentifierNode(`
	`255`	`+ functionExpression.parent`
	`256`	`+ );`
	`257`	`+ if (deepestCalleeIdentifier?.name === 'forEach') {`
	`258`	`+ return null;`
	`259`	`+ }`
	`260`	`+`
`253`	`261`	`const memberExpressionFixer = fixer.insertTextBefore(`
`254`	`262`	`node.parent,`
`255`	`263`	`'await '`

Lines changed: 19 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1460,5 +1460,24 @@ ruleTester.run(RULE_NAME, rule, {`
`1460`	`1460`	`})`
`1461`	`1461`	`,
`1462`	`1462`	`},`
	`1463`	`+ {`
	`1464`	+ code: `
	`1465`	`+ import userEvent from '${USER_EVENT_ASYNC_FRAMEWORKS[0]}'`
	`1466`	`+ test('setup method called is valid', () => {`
	`1467`	`+ const foo = [];`
	`1468`	`+ foo.forEach(() => {`
	`1469`	`+ userEvent.click();`
	`1470`	`+ });`
	`1471`	`+ })`
	`1472`	+ `,
	`1473`	`+ errors: [`
	`1474`	`+ {`
	`1475`	`+ line: 6,`
	`1476`	`+ column: 6,`
	`1477`	`+ messageId: 'awaitAsyncEvent',`
	`1478`	`+ data: { name: 'click' },`
	`1479`	`+ },`
	`1480`	`+ ],`
	`1481`	`+ },`
`1463`	`1482`	`],`
`1464`	`1483`	`});`

Comments

(0)