Commit 987fcbf

committed

Remove innerHTML check and rely on types instead. Also remove null as a valid type.

1 parent 568a330 commit 987fcbfCopy full SHA for 987fcbf

File tree

-8

lines changed

-8

lines changed

Lines changed: 0 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -46,12 +46,6 @@ test('logs messsage when element is not a valid HTML', () => {`
`46`	`46`	`expect(console.log.mock.calls[0][0]).toMatchInlineSnapshot(`
`47`	`47`	`"The element you're providing isn't a valid DOM element."`,
`48`	`48`	`)`
`49`		`- console.log.mockClear()`
`50`		`- screen.logTestingPlaygroundURL({})`
`51`		`- expect(console.log).toHaveBeenCalledTimes(1)`
`52`		`- expect(console.log.mock.calls[0][0]).toMatchInlineSnapshot(`
`53`		- `"The element you're providing isn't a valid DOM element."`,
`54`		`- )`
`55`	`49`	`})`
`56`	`50`
`57`	`51`	`test('logs Playground URL that are passed as element', () => {`

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -10,8 +10,9 @@ function encode(value: string) {`
`10`	`10`	`return compressToEncodedURIComponent(unindent(value))`
`11`	`11`	`}`
`12`	`12`
`13`		`-function getPlaygroundUrl(element: Element \| null) {`
`14`		`- if (!element \|\| !('innerHTML' in element)) {`
	`13`	`+function getPlaygroundUrl(element: Element) {`
	`14`	`+ // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition`
	`15`	`+ if (!element) {`
`15`	`16`	throw new Error(`The element you're providing isn't a valid DOM element.`)
`16`	`17`	`}`
`17`	`18`

Comments

(0)