Commit 932d6bf

committed

Throw error instead of logging

1 parent 00fb701 commit 932d6bfCopy full SHA for 932d6bf

File tree

+18

-15

lines changed

+18

-15

lines changed

Lines changed: 11 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -32,10 +32,17 @@ let config: InternalConfig = {`
`32`	`32`
`33`	`33`	`// called when getBy* queries fail. (message, container) => Error`
`34`	`34`	`getElementError(message, container) {`
`35`		`- const playgroundUrl =`
`36`		`- message &&`
`37`		`- getConfig().printPlaygroundLink &&`
`38`		`- getPlaygroundUrl(container, false)`
	`35`	`+ const playgroundUrl = (() => {`
	`36`	`+ try {`
	`37`	`+ return (`
	`38`	`+ message &&`
	`39`	`+ getConfig().printPlaygroundLink &&`
	`40`	`+ getPlaygroundUrl(container)`
	`41`	`+ )`
	`42`	`+ } catch {`
	`43`	`+ return null`
	`44`	`+ }`
	`45`	`+ })()`
`39`	`46`
`40`	`47`	`const error = new Error(`
`41`	`48`	`[`

Lines changed: 3 additions & 9 deletions

Original file line number	Diff line number	Diff line change
`@@ -10,19 +10,13 @@ function encode(value: string) {`
`10`	`10`	`return compressToEncodedURIComponent(unindent(value))`
`11`	`11`	`}`
`12`	`12`
`13`		`-function getPlaygroundUrl(element: Element \| null,logErrors=true) {`
	`13`	`+function getPlaygroundUrl(element: Element \| null) {`
`14`	`14`	`if (!element \|\| !('innerHTML' in element)) {`
`15`		`- if (logErrors) {`
`16`		- console.log(`The element you're providing isn't a valid DOM element.`)
`17`		`- }`
`18`		`- return null`
	`15`	+ throw new Error(`The element you're providing isn't a valid DOM element.`)
`19`	`16`	`}`
`20`	`17`
`21`	`18`	`if (!element.innerHTML) {`
`22`		`- if (logErrors) {`
`23`		- console.log(`The provided element doesn't have any children.`)
`24`		`- }`
`25`		`- return null`
	`19`	+ throw new Error(`The provided element doesn't have any children.`)
`26`	`20`	`}`
`27`	`21`
`28`	`22`	return `https://testing-playground.com/#markup=${encode(element.innerHTML)}`

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -10,9 +10,11 @@ const debug = (element, maxLength, options) =>`
`10`	`10`	`: logDOM(element, maxLength, options)`
`11`	`11`
`12`	`12`	`const logTestingPlaygroundURL = (element = getDocument().body) => {`
`13`		`- consturl=getPlaygroundUrl(element)`
`14`		`- if(url){`
	`13`	`+ try{`
	`14`	`+ consturl=getPlaygroundUrl(element)`
`15`	`15`	console.log(`Open this URL in your browser\n\n${url}`)
	`16`	`+ } catch (e) {`
	`17`	`+ console.log(e.message)`
`16`	`18`	`}`
`17`	`19`	`}`
`18`	`20`

Comments

(0)