Commit 2866544

kevin940726eps1lon

and

authored

feat: Prioritize accessible names check higher than inaccessibility check in byRole queries (#1068)

Co-authored-by: eps1lon <silbermann.sebastian@gmail.com>

1 parent b6b9b5b commit 2866544Copy full SHA for 2866544

File tree

-7

lines changed

-7

lines changed

Lines changed: 7 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -153,13 +153,6 @@ function queryAllByRole(`
`153`	`153`	`// don't care if aria attributes are unspecified`
`154`	`154`	`return true`
`155`	`155`	`})`
`156`		`- .filter(element => {`
`157`		`- return hidden === false`
`158`		`- ? isInaccessible(element, {`
`159`		`- isSubtreeInaccessible: cachedIsSubtreeInaccessible,`
`160`		`- }) === false`
`161`		`- : true`
`162`		`- })`
`163`	`156`	`.filter(element => {`
`164`	`157`	`if (name === undefined) {`
`165`	`158`	`// Don't care`
`@@ -176,6 +169,13 @@ function queryAllByRole(`
`176`	`169`	`text => text,`
`177`	`170`	`)`
`178`	`171`	`})`
	`172`	`+ .filter(element => {`
	`173`	`+ return hidden === false`
	`174`	`+ ? isInaccessible(element, {`
	`175`	`+ isSubtreeInaccessible: cachedIsSubtreeInaccessible,`
	`176`	`+ }) === false`
	`177`	`+ : true`
	`178`	`+ })`
`179`	`179`	`}`
`180`	`180`
`181`	`181`	`function makeRoleSelector(role, exact, customNormalizer) {`

Comments

(0)