Commit e2295c6

authored

feat: add stronger types (#413)

1 parent a5ad0c8 commit e2295c6Copy full SHA for e2295c6

File tree

2 files changed

+20

-10

lines changed

projects/testing-library/src/lib
- models.ts
- testing-library.ts

2 files changed

+20

-10

lines changed

`‎projects/testing-library/src/lib/models.ts`

Lines changed: 17 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,13 @@`
`1`		`-import { Type, DebugElement, EventEmitter, Signal, InputSignalWithTransform } from '@angular/core';`
	`1`	`+import {`
	`2`	`+ Type,`
	`3`	`+ DebugElement,`
	`4`	`+ ModuleWithProviders,`
	`5`	`+ EventEmitter,`
	`6`	`+ EnvironmentProviders,`
	`7`	`+ Provider,`
	`8`	`+ Signal,`
	`9`	`+ InputSignalWithTransform,`
	`10`	`+} from '@angular/core';`
`2`	`11`	`import { ComponentFixture, DeferBlockBehavior, DeferBlockState, TestBed } from '@angular/core/testing';`
`3`	`12`	`import { Routes } from '@angular/router';`
`4`	`13`	`import { BoundFunction, Queries, queries, Config as dtlConfig, PrettyDOMOptions } from '@testing-library/dom';`
`@@ -153,7 +162,7 @@ export interface RenderComponentOptions<ComponentType, Q extends Queries = typeo`
`153`	`162`	`* declarations: [ CustomerDetailComponent, ButtonComponent ]`
`154`	`163`	`* })`
`155`	`164`	`*/`
`156`		`- declarations?: any[];`
	`165`	`+ declarations?: (Type<unknown>\|unknown[])[];`
`157`	`166`	`/**`
`158`	`167`	`* @description`
`159`	`168`	`* A collection of providers needed to render the component via Dependency Injection, for example, injectable services or tokens.`
`@@ -174,7 +183,7 @@ export interface RenderComponentOptions<ComponentType, Q extends Queries = typeo`
`174`	`183`	`* ]`
`175`	`184`	`* })`
`176`	`185`	`*/`
`177`		`- providers?: any[];`
	`186`	`+ providers?: (Provider\|EnvironmentProviders)[];`
`178`	`187`	`/**`
`179`	`188`	`* @description`
`180`	`189`	`* A collection of imports needed to render the component, for example, shared modules.`
`@@ -192,7 +201,7 @@ export interface RenderComponentOptions<ComponentType, Q extends Queries = typeo`
`192`	`201`	`* ]`
`193`	`202`	`* })`
`194`	`203`	`*/`
`195`		`- imports?: any[];`
	`204`	`+ imports?: (Type<unknown>\|ModuleWithProviders<unknown>)[];`
`196`	`205`	`/**`
`197`	`206`	`* @description`
`198`	`207`	`* A collection of schemas needed to render the component.`
`@@ -314,7 +323,7 @@ export interface RenderComponentOptions<ComponentType, Q extends Queries = typeo`
`314`	`323`	`* ]`
`315`	`324`	`* })`
`316`	`325`	`*/`
`317`		`- componentProviders?: any[];`
	`326`	`+ componentProviders?: Provider[];`
`318`	`327`	`/**`
`319`	`328`	`* @description`
`320`	`329`	`* Collection of child component specified providers to override with`
`@@ -348,7 +357,7 @@ export interface RenderComponentOptions<ComponentType, Q extends Queries = typeo`
`348`	`357`	`* ]`
`349`	`358`	`* })`
`350`	`359`	`*/`
`351`		`- componentImports?: (Type<any> \| any[])[];`
	`360`	`+ componentImports?: (Type<unknown> \| unknown[])[];`
`352`	`361`	`/**`
`353`	`362`	`* @description`
`354`	`363`	`* Queries to bind. Overrides the default set from DOM Testing Library unless merged.`
`@@ -462,7 +471,7 @@ export interface RenderComponentOptions<ComponentType, Q extends Queries = typeo`
`462`	`471`
`463`	`472`	`export interface ComponentOverride<T> {`
`464`	`473`	`component: Type<T>;`
`465`		`- providers: any[];`
	`474`	`+ providers: Provider[];`
`466`	`475`	`}`
`467`	`476`
`468`	`477`	`// eslint-disable-next-line @typescript-eslint/no-empty-object-type`
`@@ -496,7 +505,7 @@ export interface Config extends Pick<RenderComponentOptions<any>, 'excludeCompon`
`496`	`505`	`/**`
`497`	`506`	`* Imports that are added to the imports`
`498`	`507`	`*/`
`499`		`- defaultImports: any[];`
	`508`	`+ defaultImports?: (Type<unknown>\|ModuleWithProviders<unknown>)[];`
`500`	`509`	`/**`
`501`	`510`	* Set to `true` to use zoneless change detection.
`502`	`511`	* This automatically adds `provideZonelessChangeDetection` to the default imports.

`‎projects/testing-library/src/lib/testing-library.ts`

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -6,6 +6,7 @@ import {`
`6`	`6`	`OnChanges,`
`7`	`7`	`OutputRef,`
`8`	`8`	`OutputRefSubscription,`
	`9`	`+ Provider,`
`9`	`10`	`SimpleChange,`
`10`	`11`	`SimpleChanges,`
`11`	`12`	`Type,`
`@@ -436,7 +437,7 @@ function overrideComponentImports<SutType>(sut: Type<SutType> \| string, imports:`
`436`	`437`	`function overrideChildComponentProviders(componentOverrides: ComponentOverride<any>[]) {`
`437`	`438`	`if (componentOverrides) {`
`438`	`439`	`for (const { component, providers } of componentOverrides) {`
`439`		`- TestBed.overrideComponent(component, { set: { providers } });`
	`440`	`+ TestBed.overrideComponent(component, { set: { providers: providersasProvider[] } });`
`440`	`441`	`}`
`441`	`442`	`}`
`442`	`443`	`}`
`@@ -499,7 +500,7 @@ function addAutoDeclarations<SutType>(`
`499`	`500`	`wrapper,`
`500`	`501`	`}: Pick<RenderTemplateOptions<any>, 'declarations' \| 'excludeComponentDeclaration' \| 'wrapper'>,`
`501`	`502`	`) {`
`502`		`- const nonStandaloneDeclarations = declarations?.filter((d) => !isStandalone(d));`
	`503`	`+ const nonStandaloneDeclarations = declarations.filter((d) => !isStandalone(dasType<any>));`
`503`	`504`	`if (typeof sut === 'string') {`
`504`	`505`	`if (wrapper && isStandalone(wrapper)) {`
`505`	`506`	`return nonStandaloneDeclarations;`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit e2295c6

File tree

2 files changed

2 files changed

`‎projects/testing-library/src/lib/models.ts`

`‎projects/testing-library/src/lib/testing-library.ts`

0 commit comments