Skip to content

Commit 26724ab

fatmcgav-depopbryantbiggs

and

authored

fix: Disable endpoint creation when setting create_proxy = false (#12)

Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>

1 parent 8c1720c commit 26724abCopy full SHA for 26724ab

File tree

6 files changed

+7

-7

lines changed

.pre-commit-config.yaml
examples
- mysql_iam_cluster
  - main.tf
- mysql_iam_instance
  - main.tf
- postgresql_iam_cluster
  - main.tf
- postgresql_iam_instance
  - main.tf
main.tf

6 files changed

+7

-7

lines changed

`‎.pre-commit-config.yaml`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`repos:`
`2`	`2`	`- repo: https://github.com/antonbabenko/pre-commit-terraform`
`3`		`- rev: v1.68.1`
	`3`	`+ rev: v1.74.1`
`4`	`4`	`hooks:`
`5`	`5`	`- id: terraform_fmt`
`6`	`6`	`- id: terraform_validate`
`@@ -23,7 +23,7 @@ repos:`
`23`	`23`	`- '--args=--only=terraform_standard_module_structure'`
`24`	`24`	`- '--args=--only=terraform_workspace_remote'`
`25`	`25`	`- repo: https://github.com/pre-commit/pre-commit-hooks`
`26`		`- rev: v4.2.0`
	`26`	`+ rev: v4.3.0`
`27`	`27`	`hooks:`
`28`	`28`	`- id: check-merge-conflict`
`29`	`29`	`- id: end-of-file-fixer`

`‎examples/mysql_iam_cluster/main.tf`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ module "rds_proxy" {`
`47`	`47`	`}`
`48`	`48`
`49`	`49`	`secrets = {`
`50`		`- "${local.db_username}" = {`
	`50`	`+ (local.db_username) = {`
`51`	`51`	`description = aws_secretsmanager_secret.superuser.description`
`52`	`52`	`arn = aws_secretsmanager_secret.superuser.arn`
`53`	`53`	`kms_key_id = aws_secretsmanager_secret.superuser.kms_key_id`

`‎examples/mysql_iam_instance/main.tf`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ module "rds_proxy" {`
`47`	`47`	`}`
`48`	`48`
`49`	`49`	`secrets = {`
`50`		`- "${local.db_username}" = {`
	`50`	`+ (local.db_username) = {`
`51`	`51`	`description = aws_secretsmanager_secret.superuser.description`
`52`	`52`	`arn = aws_secretsmanager_secret.superuser.arn`
`53`	`53`	`kms_key_id = aws_secretsmanager_secret.superuser.kms_key_id`

`‎examples/postgresql_iam_cluster/main.tf`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ module "rds_proxy" {`
`47`	`47`	`}`
`48`	`48`
`49`	`49`	`secrets = {`
`50`		`- "${local.db_username}" = {`
	`50`	`+ (local.db_username) = {`
`51`	`51`	`description = aws_secretsmanager_secret.superuser.description`
`52`	`52`	`arn = aws_secretsmanager_secret.superuser.arn`
`53`	`53`	`kms_key_id = aws_secretsmanager_secret.superuser.kms_key_id`

`‎examples/postgresql_iam_instance/main.tf`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ module "rds_proxy" {`
`47`	`47`	`}`
`48`	`48`
`49`	`49`	`secrets = {`
`50`		`- "${local.db_username}" = {`
	`50`	`+ (local.db_username) = {`
`51`	`51`	`description = aws_secretsmanager_secret.superuser.description`
`52`	`52`	`arn = aws_secretsmanager_secret.superuser.arn`
`53`	`53`	`kms_key_id = aws_secretsmanager_secret.superuser.kms_key_id`

`‎main.tf`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ resource "aws_db_proxy_target" "db_cluster" {`
`68`	`68`	`}`
`69`	`69`
`70`	`70`	`resource "aws_db_proxy_endpoint" "this" {`
`71`		`- for_each = var.db_proxy_endpoints`
	`71`	`+ for_each = { fork, vinvar.db_proxy_endpoints:k=>vifvar.create_proxy }`
`72`	`72`
`73`	`73`	`db_proxy_name = aws_db_proxy.this[0].name`
`74`	`74`	`db_proxy_endpoint_name = each.value.name`

0 commit comments

Comments

(0)