This repository was archived by the owner on Aug 15, 2019. It is now read-only.

Commit 0d79535

author

Nikhil Thorat

authored

Wait for yarn in webgpu / react native CI cloudbuild.yml. (#1877)

We need to wait for yarn on the parent folder because child directories will look in the parent node_modules. This introduces a race condition that causes the CI to be flaky. DEV

1 parent a516745 commit 0d79535Copy full SHA for 0d79535

File tree

1 file changed

-2

lines changed

cloudbuild.yml

1 file changed

-2

lines changed

`‎cloudbuild.yml‎`

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,8 @@ steps:`
`55`	`55`	`id: 'test-webgpu'`
`56`	`56`	`dir: 'tfjs-webgpu/'`
`57`	`57`	`args: ['test-ci']`
`58`		`- waitFor: ['-'] # start step immediately`
	`58`	`+ # Wait for parent because subfolders look at parent node_modules.`
	`59`	`+ waitFor: ['yarn']`
`59`	`60`	`#`
`60`	`61`	`# React-Native tests`
`61`	`62`	`#`
`@@ -64,7 +65,8 @@ steps:`
`64`	`65`	`id: 'test-react-native'`
`65`	`66`	`dir: 'tfjs-react-native/'`
`66`	`67`	`args: ['test-ci']`
`67`		`- waitFor: ['-'] # start step immediately`
	`68`	`+ # Wait for parent because subfolders look at parent node_modules.`
	`69`	`+ waitFor: ['yarn']`
`68`	`70`	`env: ['BROWSERSTACK_USERNAME=deeplearnjs1']`
`69`	`71`	`secretEnv: ['BROWSERSTACK_KEY']`
`70`	`72`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 0d79535

File tree

1 file changed

1 file changed

`‎cloudbuild.yml‎`

0 commit comments