Commit 3181bc7

committed

Always use calloc instead of malloc + memset

In most cases, they will be the same. In some cases, calloc() will do less work because it can skip memset() entirely. In other cases, calloc() can even cheat and not allocate any memory on modern operating systems. However, the use of malloc() + memset() will always do the full amount of work.

1 parent 9a582b8 commit 3181bc7Copy full SHA for 3181bc7

File tree

1 file changed

-4

lines changed

stack.c

1 file changed

-4

lines changed

`‎stack.c‎`

Lines changed: 2 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -4,9 +4,7 @@ void init_stack(stack_frame_t *stack, size_t entry_size)`
`4`	`4`	`{`
`5`	`5`	`memset(stack, 0, sizeof(stack_frame_t));`
`6`	`6`	`stack->max_size = entry_size;`
`7`		`- stack->store = (stack_entry_t ) malloc(sizeof(stack_entry_t) entry_size);`
`8`		`- for (size_t i = 0; i < entry_size; i++)`
`9`		`- memset(&stack->store[i], 0, sizeof(stack_entry_t));`
	`7`	`+ stack->store = calloc(sizeof(stack_entry_t), entry_size);`
`10`	`8`	`stack->size = 0;`
`11`	`9`	`}`
`12`	`10`
`@@ -111,4 +109,4 @@ size_t get_type_size(stack_entry_type_t type)`
`111`	`109`	`assert("unable to recognize stack entry's tag");`
`112`	`110`	`}`
`113`	`111`	`return size;`
`114`		`-}`
	`112`	`+}`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 3181bc7

File tree

1 file changed

1 file changed

`‎stack.c‎`

0 commit comments