Commit 75aeade

committed

Fix incorrect DROP_SIZE usage

Previously, measure() only recorded timings for indices in the middle range [DROP_SIZE, N_MEASURES - DROP_SIZE), while update_statistics() assumed all entries were available from index 0. This mismatch led to statistical analysis on unmeasured (zero-filled) samples, potentially skewing results or preventing detection thresholds from being reached. Now: - measure() records all samples - update_statistics() discards DROP_SIZE samples on both ends - Sample accounting matches ENOUGH_MEASURE estimation Change-Id: Ibb1515043da5f56d72fe34fd5c78e2283df9a993

1 parent 55065d7 commit 75aeadeCopy full SHA for 75aeade

File tree

2 files changed

-6

lines changed

dudect
- constant.c
- fixture.c

2 files changed

-6

lines changed

`‎dudect/constant.c`

Lines changed: 5 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,7 @@ bool measure(int64_t *before_ticks,`
`77`	`77`
`78`	`78`	`switch (mode) {`
`79`	`79`	`case DUT(insert_head):`
`80`		`- for (size_t i = DROP_SIZE; i < N_MEASURES-DROP_SIZE; i++) {`
	`80`	`+ for (size_t i = 0; i < N_MEASURES; i++) {`
`81`	`81`	`char *s = get_random_string();`
`82`	`82`	`dut_new();`
`83`	`83`	`dut_insert_head(`
`@@ -94,7 +94,7 @@ bool measure(int64_t *before_ticks,`
`94`	`94`	`}`
`95`	`95`	`break;`
`96`	`96`	`case DUT(insert_tail):`
`97`		`- for (size_t i = DROP_SIZE; i < N_MEASURES-DROP_SIZE; i++) {`
	`97`	`+ for (size_t i = 0; i < N_MEASURES; i++) {`
`98`	`98`	`char *s = get_random_string();`
`99`	`99`	`dut_new();`
`100`	`100`	`dut_insert_head(`
`@@ -111,7 +111,7 @@ bool measure(int64_t *before_ticks,`
`111`	`111`	`}`
`112`	`112`	`break;`
`113`	`113`	`case DUT(remove_head):`
`114`		`- for (size_t i = DROP_SIZE; i < N_MEASURES-DROP_SIZE; i++) {`
	`114`	`+ for (size_t i = 0; i < N_MEASURES; i++) {`
`115`	`115`	`dut_new();`
`116`	`116`	`dut_insert_head(`
`117`	`117`	`get_random_string(),`
`@@ -129,7 +129,7 @@ bool measure(int64_t *before_ticks,`
`129`	`129`	`}`
`130`	`130`	`break;`
`131`	`131`	`case DUT(remove_tail):`
`132`		`- for (size_t i = DROP_SIZE; i < N_MEASURES-DROP_SIZE; i++) {`
	`132`	`+ for (size_t i = 0; i < N_MEASURES; i++) {`
`133`	`133`	`dut_new();`
`134`	`134`	`dut_insert_head(`
`135`	`135`	`get_random_string(),`
`@@ -147,7 +147,7 @@ bool measure(int64_t *before_ticks,`
`147`	`147`	`}`
`148`	`148`	`break;`
`149`	`149`	`default:`
`150`		`- for (size_t i = DROP_SIZE; i < N_MEASURES-DROP_SIZE; i++) {`
	`150`	`+ for (size_t i = 0; i < N_MEASURES; i++) {`
`151`	`151`	`dut_new();`
`152`	`152`	`dut_insert_head(`
`153`	`153`	`get_random_string(),`

`‎dudect/fixture.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,7 @@ static void update_statistics(const int64_t *exec_times,`
`103`	`103`	`uint8_t *classes,`
`104`	`104`	`int64_t *percentiles)`
`105`	`105`	`{`
`106`		`- for (size_t i = 0; i < N_MEASURES; i++) {`
	`106`	`+ for (size_t i = DROP_SIZE; i < N_MEASURES-DROP_SIZE; i++) {`
`107`	`107`	`int64_t difference = exec_times[i];`
`108`	`108`	`/* CPU cycle counter overflowed or dropped measurement */`
`109`	`109`	`if (difference <= 0)`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 75aeade

File tree

2 files changed

2 files changed

`‎dudect/constant.c`

`‎dudect/fixture.c`

0 commit comments