This repository was archived by the owner on Dec 5, 2022. It is now read-only.

Commit 3716acf

committed

minor #28025 Use an empty string as default for assertEquals (DavidPrevot)

This PR was merged into the 3.4 branch. Discussion ---------- Use an empty string as default for assertEquals Make sure it isn’t interpreted as a type NULL, making the test fail with PHPUnit 7.2. | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT This shouldn’t break the existing tests, but will also make them work with recent PHPUnit. Commits ------- 31353147a3 Use an empty string as default for assertEquals

2 parents 351b74b + ebdecd5 commit 3716acfCopy full SHA for 3716acf

File tree

1 file changed

-1

lines changed

Tests
- ClassMapGeneratorTest.php

1 file changed

-1

lines changed

`‎Tests/ClassMapGeneratorTest.php‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -138,7 +138,7 @@ public function testCreateMapFinderSupport()`
`138`	`138`	`), ClassMapGenerator::createMap($finder));`
`139`	`139`	`}`
`140`	`140`
`141`		`- protected function assertEqualsNormalized($expected, $actual, $message = null)`
	`141`	`+ protected function assertEqualsNormalized($expected, $actual, $message = '')`
`142`	`142`	`{`
`143`	`143`	`foreach ($expected as $ns => $path) {`
`144`	`144`	`$expected[$ns] = str_replace('\\', '/', $path);`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit 3716acf

File tree

1 file changed

1 file changed

`‎Tests/ClassMapGeneratorTest.php‎`

0 commit comments