Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Commit 9c73250

Browse files
update
1 parent 9187f6b commit 9c73250

File tree

4 files changed

+8
-13
lines changed

4 files changed

+8
-13
lines changed

‎README.md‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ Please note that using videos from URLs requires ensuring that you have the righ
134134
| **NotAutoPlay** | Indicates if the video should not play after initialization. Notice that if you use `command` as a control flow for the player the start command should be `.idle` | false |
135135
| **EnableVector** | Use this struct to activate settings that allow the addition of vector-based overlays via commands. If it is not passed via settings, any commands to `addVector` or `removeAllVectors` will have no effect. | Not Enabled |
136136
|**PictureInPicture**| Enable Picture-in-Picture (PiP) support. If not passed than any command like `startPiP` or `stopPiP` have no effect. Take a look the example app *Video11.swift*. It does not work on simulator. You can observe the feature only on real devices.| - |
137-
| **Events([.durationAny, .itemStatusChangedAny])** | If `Events([])` is not passed in the `settings: VideoSettings`, the event mechanism is disabled. You can specify exactly which events you want to receive (e.g., .itemStatusChangedAny) or simply pass .all to receive all available events. This setting was added to improve performance because events are emitted via @State changes, which trigger view updates. If you don’t need to observe any events, disabling them can significantly boost performance. Take a look on the implementation in the example app *Video8.swift* | - |
137+
| **Events([.durationAny, .itemStatusChangedAny])** | If `Events([])` is not passed in the `settings: VideoSettings`, the event mechanism is disabled. You can specify exactly which events you want to receive (e.g., .itemStatusChangedAny) or simply pass `Events([])` to receive all available events. This setting was added to improve performance because events are emitted via @State changes, which trigger view updates. If you don’t need to observe any events, disabling them can significantly boost performance. Take a look on the implementation in the example app *Video8.swift* | - |
138138

139139
### Additional Notes on Settings
140140

@@ -325,8 +325,6 @@ video_main.m3u8
325325
| `stoppedPiP` | Matches exactly the `.stoppedPiP` event, triggered when Picture-in-Picture (PiP) mode stops. |
326326
| `itemStatusChangedAny` | Matches any `.itemStatusChanged(...)` case, indicating that the AVPlayerItem's status has changed (e.g., `.unknown`, `.readyToPlay`, `.failed`). |
327327
| `durationAny` | Matches any `.duration(...)` case, which provides the duration of the media item when ready to play. |
328-
| `all` | Matches every possible player event. |
329-
330328

331329

332330
### Additional Notes on Errors

‎Sources/swiftui-loop-videoplayer/ExtVideoPlayer.swift‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,10 +125,14 @@ fileprivate func filterEvents(with settings: VideoSettings, for events: [PlayerE
125125
let filters = settings.events // `[PlayerEventFilter]`
126126

127127
// If no filters are provided, return an empty array.
128-
guard !filters.isEmpty else {
128+
guard letfilters else {
129129
return []
130130
}
131131

132+
guard !filters.isEmpty else{
133+
return events
134+
}
135+
132136
// Keep each `PlayerEvent` only if it matches *at least* one filter in `filters`.
133137
return events.filter { event in
134138
filters.contains(event)

‎Sources/swiftui-loop-videoplayer/enum/PlayerEventFilter.swift‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,6 @@ public enum PlayerEventFilter {
5151

5252
/// Matches any `.duration(...)` case
5353
case durationAny
54-
55-
/// Matches every possible event
56-
case all
5754
}
5855

5956
extension PlayerEventFilter {
@@ -63,10 +60,6 @@ extension PlayerEventFilter {
6360
/// - Returns: `true` if the event belongs to this case (ignoring parameters), `false` otherwise.
6461
func matches(_ event: PlayerEvent) -> Bool {
6562
switch (self, event) {
66-
/// Universal case
67-
case (.all, _):
68-
return true
69-
7063
// Compare by case name only, ignoring associated values
7164
case (.seekAny, .seek):
7265
return true

‎Sources/swiftui-loop-videoplayer/utils/VideoSettings.swift‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public struct VideoSettings: Equatable{
3636
public let vector: Bool
3737

3838
/// Disable events
39-
public let events: [PlayerEventFilter]
39+
public let events: [PlayerEventFilter]?
4040

4141
/// Don't auto play video after initialization
4242
public let notAutoPlay: Bool
@@ -117,7 +117,7 @@ public struct VideoSettings: Equatable{
117117

118118
vector = settings.contains(.vector)
119119

120-
events = settings.fetch(by : "events", defaulted: [])
120+
events = settings.fetch(by : "events", defaulted: nil)
121121
}
122122
}
123123

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /