Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Product image selection should only include a slash after the repo if needed #1020

Open

Description

Currently a slash is always appended to the repo.

let image = format!("{repo}/{image_base_name}:{product_version}-stackable{stackable_version}",);

While it will probably work if users add a / themselves to the repo it would not be unheard of to cause trouble.
We should therefore only conditionally append the slash.

This behavior is documented in our docs and references this issue so as part of fixing this issue those docs need to be adjusted as well.

  • Slash is only appended when repo does not already end with a slash
  • Documentation is updated to remove the reference to this issue

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

        AltStyle によって変換されたページ (->オリジナル) /