Commit dcdd947

committed

fix: let sqlc output nullable array

Close #1851 This remove 2 assumptions from the code: - type cast are no longer always non null - postgres can output nullable array

1 parent 6389cdc commit dcdd947Copy full SHA for dcdd947

File tree

-2

lines changed

-2

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ func parseIdentifierString(name string) (*plugin.Identifier, error) {`
`36`	`36`
`37`	`37`	`func postgresType(req plugin.GenerateRequest, options opts.Options, col *plugin.Column) string {`
`38`	`38`	`columnType := sdk.DataType(col.Type)`
`39`		`- notNull := col.NotNull\|\|col.IsArray`
	`39`	`+ notNull := col.NotNull`
`40`	`40`	`driver := parseDriver(options.SqlPackage)`
`41`	`41`	`emitPointersForNull := driver.IsPGX() && options.EmitPointersForNullTypes`
`42`	`42`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -512,7 +512,7 @@ func (comp Compiler) resolveCatalogRefs(qc QueryCatalog, rvs []*ast.RangeVar,`
`512`	`512`	`return nil, fmt.Errorf("*ast.TypeCast has nil type name")`
`513`	`513`	`}`
`514`	`514`	`col := toColumn(n.TypeName)`
`515`		`- defaultP := named.NewInferredParam(col.Name, col.NotNull)`
	`515`	`+ defaultP := named.NewInferredParam(col.Name, false)`
`516`	`516`	`p, _ := params.FetchMerge(ref.ref.Number, defaultP)`
`517`	`517`
`518`	`518`	`col.Name = p.Name()`

Comments

(0)