Commit 3a4ffcb

committed

feat(impv): Support Jedis

1 parent b0b6ae8 commit 3a4ffcbCopy full SHA for 3a4ffcb

File tree

+39

-0

lines changed

+39

-0

lines changed

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -48,6 +48,7 @@`
`48`	`48`
`49`	`49`	`/**`
`50`	`50`	`* @author Dengliming`
	`51`	`+ * @author Jeonggyu Choi`
`51`	`52`	`* @since 2.3`
`52`	`53`	`*/`
`53`	`54`	`class JedisClusterStreamCommands implements RedisStreamCommands {`
`@@ -283,6 +284,10 @@ public PendingMessages xPending(byte[] key, String groupName, XPendingOptions op`
`283`	`284`	`pendingParams = pendingParams.consumer(consumerName);`
`284`	`285`	`}`
`285`	`286`
	`287`	`+ if (options.hasIdle()) {`
	`288`	`+ pendingParams = pendingParams.idle(options.getIdleMillis());`
	`289`	`+ }`
	`290`	`+`
`286`	`291`	`List<Object> response = connection.getCluster().xpending(key, group, pendingParams);`
`287`	`292`
`288`	`293`	`return StreamConverters.toPendingMessages(groupName, range,`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -55,6 +55,7 @@`
`55`	`55`	`*`
`56`	`56`	`* @author dengliming`
`57`	`57`	`* @author Mark Paluch`
	`58`	`+ * @author Jeonggyu Choi`
`58`	`59`	`* @since 2.3`
`59`	`60`	`*/`
`60`	`61`	`class StreamConverters {`
`@@ -306,6 +307,9 @@ public static XPendingParams toXPendingParams(RedisStreamCommands.XPendingOption`
`306`	`307`	`if (options.hasConsumer()) {`
`307`	`308`	`xPendingParams.consumer(options.getConsumerName());`
`308`	`309`	`}`
	`310`	`+ if (options.hasIdle()) {`
	`311`	`+ xPendingParams.idle(options.getIdleMillis());`
	`312`	`+ }`
`309`	`313`
`310`	`314`	`return xPendingParams;`
`311`	`315`	`}`

Lines changed: 30 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,30 @@`
	`1`	`+package org.springframework.data.redis.connection.jedis;`
	`2`	`+`
	`3`	`+import static org.assertj.core.api.Assertions.*;`
	`4`	`+`
	`5`	`+import redis.clients.jedis.params.XPendingParams;`
	`6`	`+`
	`7`	`+import java.lang.reflect.Field;`
	`8`	`+import java.time.Duration;`
	`9`	`+import java.time.temporal.ChronoUnit;`
	`10`	`+`
	`11`	`+import org.junit.jupiter.api.Test;`
	`12`	`+import org.springframework.data.redis.connection.RedisStreamCommands.XPendingOptions;`
	`13`	`+`
	`14`	`+/**`
	`15`	`+ * @author Jeonggyu Choi`
	`16`	`+ */`
	`17`	`+class StreamConvertersUnitTest {`
	`18`	`+`
	`19`	`+ @Test // GH-2046`
	`20`	`+ void shouldConvertIdle() throws NoSuchFieldException, IllegalAccessException {`
	`21`	`+ XPendingOptions options = XPendingOptions.unbounded(5L).idle(Duration.of(1, ChronoUnit.HOURS));`
	`22`	`+`
	`23`	`+ XPendingParams xPendingParams = StreamConverters.toXPendingParams(options);`
	`24`	`+`
	`25`	`+ Field idle = XPendingParams.class.getDeclaredField("idle");`
	`26`	`+ idle.setAccessible(true);`
	`27`	`+ Long idleValue = (Long) idle.get(xPendingParams);`
	`28`	`+ assertThat(idleValue).isEqualTo(Duration.of(1, ChronoUnit.HOURS).toMillis());`
	`29`	`+ }`
	`30`	`+}`

Comments

(0)