Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[BUG] LFS objects are not always detected! #1763

Closed
Assignees
@goran-w

Description

In methods CommitDetail.SetViewingBlobAsync() and FileHistoriesSingleRevision.GetRevisionFileContentAsync(), when processing a ObjectType.Blob the Commands.IsBinary() check is made BEFORE the LFSObject.Parse() check!

This sometimes causes an LFS object to be wrongly detected as a Binary object and displayed as such, which is clearly a bug. Currently, this in turn leads to either (wrongly) displaying the BINARY FILE NOT SUPPORTED!!! indication, or trying to display the file as an image but failing.
(Example: JPG 0 x 0 0 B)

The fix is simple - make sure to check if the Blob uses LFS before checking if it's Binary / Text.

Metadata

Metadata

Labels

No labels
No labels

Projects

No projects

Milestone

No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      AltStyle によって変換されたページ (->オリジナル) /