Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Missing call to base-class method OnFrameworkInitializationCompleted #912

Unanswered
wl2776 asked this question in Q&A
Discussion options

I've found that OnFrameworkInitializationCompleted doesn't call base.OnFrameworkInitializationCompleted() as recommended in https://docs.avaloniaui.net/docs/concepts/application-lifetimes

Was this call omitted by intent or accidentally?

I've tried adding it but haven't noticed that anything is changed.

You must be logged in to vote

Replies: 2 comments 1 reply

Comment options

I've tried adding it but haven't noticed that anything is changed.

Probably, this is OK, that nothing has changed, because this method is empty: https://github.com/AvaloniaUI/Avalonia/blob/230e4fdf1d2c6d96c0cb6445c857b1841fa6aabb/src/Avalonia.Controls/Application.cs#L286

Nevertheless, it is better to add this call.

You must be logged in to vote
0 replies
Comment options

as recommended in https://docs.avaloniaui.net/docs/concepts/application-lifetimes

Can find the sentence that states that

See also https://docs.avaloniaui.net/docs/concepts/the-main-window
Calling it wouldn't hurt anything, but why you think that's better?

You must be logged in to vote
1 reply
Comment options

Can find the sentence that states that

Second code block. Only one sample doesn't contain this call.

why you think that's better?

It is safe to omit it now, when base method is empty.
If it would do something in future versions, we could have problems on update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Category
Q&A
Labels
None yet

AltStyle によって変換されたページ (->オリジナル) /