-
Notifications
You must be signed in to change notification settings - Fork 282
-
I've found that OnFrameworkInitializationCompleted doesn't call base.OnFrameworkInitializationCompleted() as recommended in https://docs.avaloniaui.net/docs/concepts/application-lifetimes
Was this call omitted by intent or accidentally?
I've tried adding it but haven't noticed that anything is changed.
Beta Was this translation helpful? Give feedback.
All reactions
Replies: 2 comments 1 reply
-
I've tried adding it but haven't noticed that anything is changed.
Probably, this is OK, that nothing has changed, because this method is empty: https://github.com/AvaloniaUI/Avalonia/blob/230e4fdf1d2c6d96c0cb6445c857b1841fa6aabb/src/Avalonia.Controls/Application.cs#L286
Nevertheless, it is better to add this call.
Beta Was this translation helpful? Give feedback.
All reactions
-
as recommended in https://docs.avaloniaui.net/docs/concepts/application-lifetimes
Can find the sentence that states that
See also https://docs.avaloniaui.net/docs/concepts/the-main-window
Calling it wouldn't hurt anything, but why you think that's better?
Beta Was this translation helpful? Give feedback.
All reactions
-
Can find the sentence that states that
Second code block. Only one sample doesn't contain this call.
why you think that's better?
It is safe to omit it now, when base method is empty.
If it would do something in future versions, we could have problems on update.
Beta Was this translation helpful? Give feedback.