Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit ec84369

Browse files
fix: System.ArgumentException when hover the commit link multiple times before the first time tooltip shows (#765)
1 parent f028513 commit ec84369

File tree

1 file changed

+26
-23
lines changed

1 file changed

+26
-23
lines changed

‎src/Views/InteractiveRebase.axaml

Lines changed: 26 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@
6565
<Setter Property="Margin" Value="0"/>
6666
<Setter Property="Padding" Value="0"/>
6767
<Setter Property="Height" Value="28"/>
68+
<Setter Property="HorizontalContentAlignment" Value="Stretch"/>
6869
</Style>
6970
</ListBox.Styles>
7071

@@ -76,7 +77,7 @@
7677

7778
<ListBox.ItemTemplate>
7879
<DataTemplate DataType="vm:InteractiveRebaseItem">
79-
<Grid ColumnDefinitions="16,110,*,140,96,156,32,32">
80+
<Grid ColumnDefinitions="16,110,*,456"ClipToBounds="True">
8081
<!-- Drag & Drop Anchor -->
8182
<Border Grid.Column="0" Background="Transparent"
8283
Loaded="OnSetupRowHeaderDragDrop"
@@ -187,40 +188,42 @@
187188
<TextBlock Grid.Column="1" Classes="primary" Margin="0,0,4,0" Text="{Binding Subject}"/>
188189
</Grid>
189190

190-
<!-- Author -->
191-
<Grid Grid.Column="3"ColumnDefinitions="Auto,*"Width="140"ClipToBounds="True">
191+
<Grid Grid.Column="3"ColumnDefinitions="32,108,96,156,32,32"IsHitTestVisible="False"ClipToBounds="True">
192+
<!-- Author Avatar -->
192193
<v:Avatar Grid.Column="0"
193194
Width="16" Height="16"
194195
Margin="8,0,0,0"
195196
VerticalAlignment="Center"
196-
IsHitTestVisible="False"
197197
User="{Binding Commit.Author}"/>
198+
199+
<!-- Author Name -->
198200
<TextBlock Grid.Column="1"
199201
Classes="primary"
202+
MaxWidth="90"
200203
Margin="6,0,12,0"
201204
Text="{Binding Commit.Author.Name}"
202205
HorizontalAlignment="Left"/>
203-
</Grid>
204-
205-
<!-- Commit SHA -->
206-
<Border Grid.Column="4" IsHitTestVisible="False" ClipToBounds="True">
207-
<TextBlock Classes="primary"
208-
Text="{Binding Commit.SHA, Converter={x:Static c:StringConverters.ToShortSHA}}"
209-
HorizontalAlignment="Center"/>
210-
</Border>
211206

212-
<!-- Commit Time -->
213-
<TextBlock Grid.Column="5" Classes="primary" Text="{Binding Commit.CommitterTimeStr}" Margin="8,0"/>
207+
<!-- Commit SHA -->
208+
<Border Grid.Column="2" ClipToBounds="True">
209+
<TextBlock Classes="primary"
210+
Text="{Binding Commit.SHA, Converter={x:Static c:StringConverters.ToShortSHA}}"
211+
HorizontalAlignment="Center"/>
212+
</Border>
214213

215-
<!-- MoveUp Button -->
216-
<Button Grid.Column="6" Classes="icon_button" Click="OnMoveItemUp" ToolTip.Tip="Alt+Up">
217-
<Path Width="14" Height="14" Margin="0,4,0,0" Data="{StaticResource Icons.Up}"/>
218-
</Button>
219-
220-
<!-- MoveDown Button -->
221-
<Button Grid.Column="7" Classes="icon_button" Click="OnMoveItemDown" ToolTip.Tip="Alt+Down">
222-
<Path Width="14" Height="14" Margin="0,4,0,0" Data="{StaticResource Icons.Down}"/>
223-
</Button>
214+
<!-- Commit Time -->
215+
<TextBlock Grid.Column="3" Classes="primary" Text="{Binding Commit.CommitterTimeStr}" Margin="8,0"/>
216+
217+
<!-- MoveUp Button -->
218+
<Button Grid.Column="4" Classes="icon_button" Click="OnMoveItemUp" ToolTip.Tip="Alt+Up">
219+
<Path Width="14" Height="14" Margin="0,4,0,0" Data="{StaticResource Icons.Up}"/>
220+
</Button>
221+
222+
<!-- MoveDown Button -->
223+
<Button Grid.Column="5" Classes="icon_button" Click="OnMoveItemDown" ToolTip.Tip="Alt+Down">
224+
<Path Width="14" Height="14" Margin="0,4,0,0" Data="{StaticResource Icons.Down}"/>
225+
</Button>
226+
</Grid>
224227
</Grid>
225228
</DataTemplate>
226229
</ListBox.ItemTemplate>

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /