Commit 48725a7

committed

code_review: PR #612

Signed-off-by: leo <longshuang@msn.cn>

1 parent a363f67 commit 48725a7Copy full SHA for 48725a7

File tree

-15

lines changed

-15

lines changed

Lines changed: 2 additions & 15 deletions

Original file line number	Diff line number	Diff line change
`@@ -50,22 +50,9 @@ public static int Compare(string s1, string s2)`
`50`	`50`	`string sub2 = new string(tmp2, 0, loc2);`
`51`	`51`	`int result;`
`52`	`52`	`if (isDigit1 && isDigit2)`
`53`		`- {`
`54`		`- // compare numeric values`
`55`		`- if (sub1.Length == sub2.Length)`
`56`		`- {`
`57`		`- // if length is the same, lexicographical comparison is good also for numbers`
`58`		`- result = string.CompareOrdinal(sub1, sub2);`
`59`		`- }`
`60`		`- else`
`61`		`- {`
`62`		`- result = sub1.Length.CompareTo(sub2.Length);`
`63`		`- }`
`64`		`- }`
	`53`	`+ result = loc1 == loc2 ? string.CompareOrdinal(sub1, sub2) : loc1 - loc2;`
`65`	`54`	`else`
`66`		`- {`
`67`		`- result = string.Compare(sub1, sub2, System.StringComparison.Ordinal);`
`68`		`- }`
	`55`	`+ result = string.CompareOrdinal(sub1, sub2);`
`69`	`56`
`70`	`57`	`if (result != 0)`
`71`	`58`	`return result;`

Comments

(0)