Commit 142ee5a

committed

ux: use localized text instead of hard-coded string annotated (#1305)

1 parent afc8a77 commit 142ee5aCopy full SHA for 142ee5a

File tree

2 files changed

-10

lines changed

src
- Commands
  - QueryTags.cs
- Views
  - TagsView.axaml

2 files changed

-10

lines changed

`‎src/Commands/QueryTags.cs`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -29,14 +29,13 @@ public QueryTags(string repo)`
`29`	`29`	`continue;`
`30`	`30`
`31`	`31`	`var name = subs[0].Substring(10);`
`32`		`- var message = subs[5].Trim();`
`33`	`32`	`tags.Add(new Models.Tag()`
`34`	`33`	`{`
`35`	`34`	`Name = name,`
`36`	`35`	`IsAnnotated = subs[1].Equals("tag", StringComparison.Ordinal),`
`37`	`36`	`SHA = string.IsNullOrEmpty(subs[3]) ? subs[2] : subs[3],`
`38`	`37`	`CreatorDate = ulong.Parse(subs[4]),`
`39`		`- Message = string.IsNullOrEmpty(message)?name:message,`
	`38`	`+ Message = subs[5].Trim(),`
`40`	`39`	`});`
`41`	`40`	`}`
`42`	`41`

`‎src/Views/TagsView.axaml`

Lines changed: 8 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -29,16 +29,16 @@`
`29`	`29`	`<Border Height="24" Background="Transparent" PointerPressed="OnRowPointerPressed" DoubleTapped="OnDoubleTappedNode" ContextRequested="OnRowContextRequested" ToolTip.Tip="{Binding ToolTip}">`
`30`	`30`	`<Border.DataTemplates>`
`31`	`31`	`<DataTemplate DataType="vm:TagTreeNodeToolTip">`
`32`		`- <StackPanel Orientation="Vertical" MinWidth="200">`
`33`		`- <StackPanel Orientation="Horizontal"Margin="0,0,0,6">`
	`32`	`+ <StackPanel Orientation="Vertical" Spacing="6">`
	`33`	`+ <StackPanel Orientation="Horizontal">`
`34`	`34`	`<Path Width="10" Height="10" Data="{StaticResource Icons.Tag}"/>`
`35`	`35`	`<TextBlock FontWeight="Bold" Margin="4,0,0,0" Text="{Binding Name}"/>`
`36`	`36`	`<Border Background="Green" Margin="4,0,0,0" CornerRadius="4" IsVisible="{Binding IsAnnotated}">`
`37`		`- <TextBlock Text="annotated" Classes="primary" Margin="4,0" Foreground="#FFDDDDDD"/>`
	`37`	`+ <TextBlock Text="{DynamicResource Text.CreateTag.Type.Annotated}" Classes="primary" Margin="4,0" Foreground="#FFDDDDDD"/>`
`38`	`38`	`</Border>`
`39`	`39`	`</StackPanel>`
`40`	`40`
`41`		`- <TextBlock Text="{Binding Message}"/>`
	`41`	`+ <TextBlock Text="{Binding Message}"IsVisible="{Binding Message, Converter={x:Static c:StringConverters.IsNotNullOrWhitespace}}"/>`
`42`	`42`	`</StackPanel>`
`43`	`43`	`</DataTemplate>`
`44`	`44`	`</Border.DataTemplates>`
`@@ -86,16 +86,16 @@`
`86`	`86`	`<DataTemplate DataType="m:Tag">`
`87`	`87`	`<Border Height="24" Background="Transparent" PointerPressed="OnRowPointerPressed" ContextRequested="OnRowContextRequested">`
`88`	`88`	`<ToolTip.Tip>`
`89`		`- <StackPanel Orientation="Vertical" MinWidth="200">`
`90`		`- <StackPanel Orientation="Horizontal"Margin="0,0,0,6">`
	`89`	`+ <StackPanel Orientation="Vertical" Spacing="6">`
	`90`	`+ <StackPanel Orientation="Horizontal">`
`91`	`91`	`<Path Width="10" Height="10" Data="{StaticResource Icons.Tag}"/>`
`92`	`92`	`<TextBlock FontWeight="Bold" Margin="4,0,0,0" Text="{Binding Name}"/>`
`93`	`93`	`<Border Background="Green" Margin="4,0,0,0" CornerRadius="4" IsVisible="{Binding IsAnnotated}">`
`94`		`- <TextBlock Text="annotated" Classes="primary" Margin="4,0" Foreground="#FFDDDDDD"/>`
	`94`	`+ <TextBlock Text="{DynamicResource Text.CreateTag.Type.Annotated}" Classes="primary" Margin="4,0" Foreground="#FFDDDDDD"/>`
`95`	`95`	`</Border>`
`96`	`96`	`</StackPanel>`
`97`	`97`
`98`		`- <TextBlock Text="{Binding Message}"/>`
	`98`	`+ <TextBlock Text="{Binding Message}"IsVisible="{Binding Message, Converter={x:Static c:StringConverters.IsNotNullOrWhitespace}}"/>`
`99`	`99`	`</StackPanel>`
`100`	`100`	`</ToolTip.Tip>`
`101`	`101`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 142ee5a

File tree

2 files changed

2 files changed

`‎src/Commands/QueryTags.cs`

`‎src/Views/TagsView.axaml`

0 commit comments