-
-
Notifications
You must be signed in to change notification settings - Fork 107
There is no section about development. The library looks quite interesting. And recent. And the docs are nicely made.
But it is not clear whether the team welcomes contributions from outside. E.g. among all tree-based ensemble classifiers the ExtraTreesClassifier usually serves me best. Here we have RandomForestClassifier only. I love Rust and would probably take the challenge of implementing a well parallelized version of ExtraTreesClassifier (and maybe regressor) but it is not clear whether the team would welcome such contribution. I suggest adding a few lines about development contribs in the readme file of the repo.
All reactions
-
👍 1
Replies: 6 comments 3 replies
Hi, you are perfectly right.
Contributions are welcome in accordance to license and common Github code of conduct.
We have not had time to care about the developer experience side of things unfortunately, I will try to add a code of conduct and some templates for opening PRs and issues.
All reactions
We now have contribution guidelines
All reactions
Great work! Thank you!
All reactions
I would also suggest a place with a list of features so that a new developer might come and pick one (maybe Trello, maybe Projects tab in this repo or maybe just an issue with a list).
Among things that I usually use I can think of simple imputer (median, mean), robust scaler (I saw standard scaler only), imbalanced learning data preprocessors, feature selectors, pipeline (similar to sklearn but that might require architectural changes) and so on. Sorry if some of that is already implemented. Meanwhile, I guess new features can be ad hoc discussed at the discussion board
All reactions
usually technical discussions take place in comments so they can be kept with the code for future reference.
All reactions
We have right now several issues with the label help-wanted. You can filter the issues with that label. What do you think? Is that enough?
All reactions
-
👍 1
yes exactly. anybody can open issues and tag them accordingly to how newcomer-friendly they are.
All reactions
(削除) I will also add a good-first-issue or good-for-newcomers label for issues (削除ここまで)
there is a good fist issue label that we should add to the issues