Commit c32450e

anaghav2023 anaghav2023

authored

[plugin][smartling]:ENG-10295 Ability to add content entries to existing job (BuilderIO#4146)

## Description 1. Adding content entries to existing jobs was not working because the content status was still published. 2. View translation job button was not showing earlier due to the cache checks which don't work.

1 parent f818ac4 commit c32450eCopy full SHA for c32450e

4 files changed

Lines changed: 5 additions & 16 deletions

File tree

plugins/smartling

`‎plugins/smartling/package-lock.json‎`

Lines changed: 2 additions & 2 deletions

Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

`‎plugins/smartling/package.json‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@builder.io/plugin-smartling",`
`3`		`- "version": "0.0.23-7",`
	`3`	`+ "version": "0.0.23-8",`
`4`	`4`	`"description": "",`
`5`	`5`	`"keywords": [],`
`6`	`6`	`"main": "dist/plugin.system.js",`

`‎plugins/smartling/src/plugin.tsx‎`

Lines changed: 1 addition & 13 deletions

Original file line number	Diff line number	Diff line change
`@@ -664,22 +664,10 @@ const initializeSmartlingPlugin = async () => {`
`664`	`664`	`return false;`
`665`	`665`	`}`
`666`	`666`
`667`		`- // Show if content has a translation job ID (regardless of status)`
`668`	`667`	`if (!translationJobId) {`
`669`	`668`	`return false;`
`670`	`669`	`}`
`671`		`-`
`672`		`-`
`673`		`- // Trigger background validation and cleanup if needed`
`674`		`- isContentInActiveTranslationJob(content, api).catch(() => {});`
`675`		`-`
`676`		`- // Check cache for immediate result`
`677`		`- const cached = jobExistenceCache.get(translationJobId);`
`678`		`- if (cached && (Date.now() - cached.timestamp) < CACHE_DURATION) {`
`679`		`- return cached.exists; // Show only if job exists`
`680`		`- }`
`681`		`-`
`682`		`- // Default to showing while we validate (will hide after background check completes)`
	`670`	`+`
`683`	`671`	`return true;`
`684`	`672`	`},`
`685`	`673`	`async onClick(content) {`

`‎plugins/smartling/src/smartling.ts‎`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -156,6 +156,7 @@ export class SmartlingApi {`
`156`	`156`	`...allContent.map(c => getContentReference(c)),`
`157`	`157`	`],`
`158`	`158`	`},`
	`159`	`+ published: 'draft',`
`159`	`160`	`};`
`160`	`161`
`161`	`162`	`const symbolCount = allContent.length - content.length;`

0 commit comments

Comments

(0)