Commit c042d67

authored

fix[gen1-react]: passing custom breakpoints down to symbol (BuilderIO#4128)

## Description when we passed content of symbol down - we do a deepClone and here we were skipping `meta` field that contains the breakpoints object i think it's safe to clone meta field too? Jira https://builder-io.atlassian.net/browse/ENG-10131 loom: https://www.loom.com/share/c31a74790c6d4aac9d9375dcf8a3ce69

1 parent 957583c commit c042d67Copy full SHA for c042d67

2 files changed

Lines changed: 11 additions & 2 deletions

File tree

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,5 @@`
	`1`	`+---`
	`2`	`+"@builder.io/react": patch`
	`3`	`+---`
	`4`	`+`
	`5`	`+fix passing down custom breakpoints to Symbol`

Lines changed: 6 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -41,8 +41,12 @@ export function deepCloneWithConditions<T = any>(obj: T): T {`
`41`	`41`	`const clonedObj: any = {};`
`42`	`42`
`43`	`43`	`for (const key in obj) {`
`44`		`- if (key !== 'meta' && Object.prototype.hasOwnProperty.call(obj, key)) {`
`45`		`- clonedObj[key] = deepCloneWithConditions(obj[key]);`
	`44`	`+ if (Object.prototype.hasOwnProperty.call(obj, key)) {`
	`45`	`+ if (key === 'meta') {`
	`46`	`+ clonedObj.meta = obj['meta'];`
	`47`	`+ } else {`
	`48`	`+ clonedObj[key] = deepCloneWithConditions(obj[key]);`
	`49`	`+ }`
`46`	`50`	`}`
`47`	`51`	`}`
`48`	`52`

Comments

(0)