Commit fe3b4ad

authored

Merge pull request #227 from sir-gon/develop

[REFACTOR] sonarcloud fixes: Loops should be simplified using the "Wh...

2 parents 4249c0d + 3310520 commit fe3b4adCopy full SHA for fe3b4ad

File tree

-17

lines changed

src/algorithm_exercises_csharp/hackerrank/interview_preparation_kit
- arrays
  - NewYearChaos.cs
- dictionaries_and_hashmaps
  - RansomNote.cs

-17

lines changed

Lines changed: 2 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -27,13 +27,8 @@ public static int minimumBribesCalculate(List<int> q)`
`27`	`27`
`28`	`28`	`List<int> fragment = q[Math.Min(Math.Max(value - 2, 0), i)..i];`
`29`	`29`
`30`		`- foreach (int k in fragment)`
`31`		`- {`
`32`		`- if (k > value)`
`33`		`- {`
`34`		`- bribes += 1;`
`35`		`- }`
`36`		`- }`
	`30`	`+ bribes += fragment.Count(k => k > value);`
	`31`	`+`
`37`	`32`	`i += 1;`
`38`	`33`	`}`
`39`	`34`

Lines changed: 3 additions & 10 deletions

Original file line number	Diff line number	Diff line change
`@@ -32,16 +32,9 @@ public static bool checkMagazineCompute(List<string> magazine, List<string> note`
`32`	`32`	`ArgumentNullException.ThrowIfNull(magazine);`
`33`	`33`	`ArgumentNullException.ThrowIfNull(note);`
`34`	`34`
`35`		`- Dictionary<string, int> dictionary = [];`
`36`		`-`
`37`		`- foreach (string word in magazine)`
`38`		`- {`
`39`		`- if (!dictionary.TryAdd(word, 1))`
`40`		`- {`
`41`		`- int currentValue = dictionary[word];`
`42`		`- dictionary[word] = currentValue + 1;`
`43`		`- }`
`44`		`- }`
	`35`	`+ Dictionary<string, int> dictionary = magazine`
	`36`	`+ .GroupBy(word => word)`
	`37`	`+ .ToDictionary(g => g.Key, g => g.Count());`
`45`	`38`
`46`	`39`	`foreach (string word in note)`
`47`	`40`	`{`

Comments

(0)