Commit cad1e91

mykauldkropachev

authored and

committed

(minor improvement): small refactoring in SimpleStrategy's make_token_replica_map()

While trying to look at some random (flaky?) test (#510 (comment) ) I saw some (minor) improvements that can be made to SimpleStrategy's make_token_replica_map(): Specifically - remove some redundant len() calls to outside the loop(s) Probably very very minor improvement, perhaps in a large cluster it'll be noticable - but no one should use SimpleStrategy anyway! Signed-off-by: Yaniv Kaul <yaniv.kaul@scylladb.com>

1 parent 1262d43 commit cad1e91Copy full SHA for cad1e91

File tree

1 file changed

-3

lines changed

cassandra
- metadata.py

1 file changed

-3

lines changed

`‎cassandra/metadata.py`

Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -569,10 +569,11 @@ def __init__(self, options_map):`
`569`	`569`
`570`	`570`	`def make_token_replica_map(self, token_to_host_owner, ring):`
`571`	`571`	`replica_map = {}`
`572`		`- for i in range(len(ring)):`
	`572`	`+ ring_len = len(ring)`
	`573`	`+ for i in range(ring_len):`
`573`	`574`	`j, hosts = 0, list()`
`574`		`- while len(hosts) < self.replication_factor and j < len(ring):`
`575`		`- token = ring[(i + j) % len(ring)]`
	`575`	`+ while len(hosts) < self.replication_factor and j < ring_len:`
	`576`	`+ token = ring[(i + j) % ring_len]`
`576`	`577`	`host = token_to_host_owner[token]`
`577`	`578`	`if host not in hosts:`
`578`	`579`	`hosts.append(host)`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit cad1e91

File tree

1 file changed

1 file changed

`‎cassandra/metadata.py`

0 commit comments