forked from paradigmxyz/reth
-
Notifications
You must be signed in to change notification settings - Fork 8
Use Database::storage in place of State<DB>::load_cache_account in Curie and Feynman transitions #286
Open
Description
Describe the bug
State<DB>::load_cache_account loads the account into cache with an empty storage, meaning the construction of the new storage would not contain the correct previous_or_original_value.
reth/crates/scroll/alloy/evm/src/block/feynman.rs
Lines 66 to 78 in 9fe1909
// init new storage
let new_storage = FEYNMAN_L1_GAS_PRICE_ORACLE_STORAGE
.into_iter()
.map(|(slot, present_value)| {
(
slot,
StorageSlot {
present_value,
previous_or_original_value: oracle.storage_slot(slot).unwrap_or_default(),
},
)
})
.collect();
The issue is not pressing as the transition only happens once, and the previous storage value would be 0 at the transition block. This should however be updated in order to avoid future mistakes.
Steps to reproduce
NA
Node logs
Platform(s)
Mac (Apple Silicon)
Container Type
Not running in a container
What version/commit are you on?
NA
What database version are you on?
NA
Which chain / network are you on?
NA
What type of node are you running?
Archive (default)
What prune config do you use, if any?
No response
If you've built Reth from source, provide the full command you used
No response
Code of Conduct
- I agree to follow the Code of Conduct
Metadata
Metadata
Assignees
Labels
No labels
Type
Fields
Give feedbackNo fields configured for issues without a type.
Projects
Status
No status