-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Remove dependency on jQuery #18903
-
Right now, ScalaDoc depends on jQuery.
From what I can tell, the main reason for it is the table of contents plugin toc.
I would like to suggest replacing jQuery and toc with vanilla JavaScript implementations. While jQuery is still maintained, most of the features are now part of the JavaScript spec, so the migration is not that painful.
On top of that, the current way things are setup doesn't play nicely with JS blockers: Scaladoc works with both JS enabled and disabled, but breaks if JS is enabled only for the page domain (and not for the CDNs)
Beta Was this translation helpful? Give feedback.
All reactions
Replies: 3 comments 1 reply
-
Seems likely a PR on this would be accepted.
Beta Was this translation helpful? Give feedback.
All reactions
-
seems related? #19208
Beta Was this translation helpful? Give feedback.
All reactions
-
I was once again looking for beginner friendly issues to contribute to. I have changes to accomplish just this! Should I create a PR referencing the discussion or does it need to link to an issue first? Here are my changes. https://github.com/Math-ias/scala3-fork/tree/discussion-18903
Beta Was this translation helpful? Give feedback.
All reactions
-
Feel free to open a PR.
Beta Was this translation helpful? Give feedback.
All reactions
-
😄 1