Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Remove dependency on jQuery #18903

JD557 started this conversation in General Discussion
Nov 12, 2023 · 3 comments · 1 reply
Discussion options

Right now, ScalaDoc depends on jQuery.

From what I can tell, the main reason for it is the table of contents plugin toc.

I would like to suggest replacing jQuery and toc with vanilla JavaScript implementations. While jQuery is still maintained, most of the features are now part of the JavaScript spec, so the migration is not that painful.

On top of that, the current way things are setup doesn't play nicely with JS blockers: Scaladoc works with both JS enabled and disabled, but breaks if JS is enabled only for the page domain (and not for the CDNs)

You must be logged in to vote

Replies: 3 comments 1 reply

Comment options

Seems likely a PR on this would be accepted.

You must be logged in to vote
0 replies
Comment options

seems related? #19208

You must be logged in to vote
0 replies
Comment options

I was once again looking for beginner friendly issues to contribute to. I have changes to accomplish just this! Should I create a PR referencing the discussion or does it need to link to an issue first? Here are my changes. https://github.com/Math-ias/scala3-fork/tree/discussion-18903

You must be logged in to vote
1 reply
Comment options

sjrd Nov 22, 2024
Maintainer

Feel free to open a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

AltStyle によって変換されたページ (->オリジナル) /