Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Commit e7db08a

Browse files
Best effort failure excluded
1 parent 7b42ed8 commit e7db08a

File tree

2 files changed

+17
-16
lines changed

2 files changed

+17
-16
lines changed

‎compiler/test/dotc/neg-best-effort-unpickling.excludelist‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,3 +27,6 @@ i23402b.scala
2727

2828
# Unhandled TypeError exception
2929
i23504.scala
30+
31+
# owner of anon, where package object has funky name
32+
i20511-1.scala

‎compiler/test/dotty/tools/dotc/BestEffortOptionsTests.scala‎

Lines changed: 14 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -2,44 +2,42 @@ package dotty
22
package tools
33
package dotc
44

5-
import scala.concurrent.duration._
6-
import dotty.tools.vulpix._
7-
import org.junit.{ Test, AfterClass }
5+
import dotty.tools.vulpix.*
86
import reporting.TestReporter
9-
import java.io.{File => JFile}
107

8+
import scala.concurrent.duration.*
119
import scala.language.unsafeNulls
1210

11+
import java.io.{File => JFile}
12+
import org.junit.{AfterClass, Test}
13+
1314
class BestEffortOptionsTests {
14-
import ParallelTesting._
15-
import vulpix.TestConfiguration._
16-
import BestEffortOptionsTests._
17-
import CompilationTest.aggregateTests
15+
import ParallelTesting.*
16+
import vulpix.TestConfiguration.*
17+
import BestEffortOptionsTests.*
1818

1919
// Since TASTy and beTASTy files are read in a lazy manner (only when referenced by the source .scala file)
2020
// we test by using the "-from-tasty" option. This guarantees that the tasty files will be read
2121
// (and that the Best Effort TASTy reader will be tested), but we unfortunately skip the useful
2222
// interactions a tree derived from beTASTy could have with other frontend phases.
23-
@Test def negTestFromBestEffortTasty: Unit = {
23+
@Test def negTestFromBestEffortTasty: Unit =
2424
// Can be reproduced with
2525
// > sbt
26-
// > scalac --Ybest-effort -Xsemanticdb <source>
27-
// > scalac --from-tasty -Ywith-best-effort-tasty META_INF/best-effort/<betasty>
26+
// > scalac -Ybest-effort -Xsemanticdb <source>
27+
// > scalac -from-tasty -Ywith-best-effort-tasty META_INF/best-effort/<betasty>
2828

29-
implicitvaltestGroup: TestGroup = TestGroup("negTestFromBestEffortTasty")
29+
given TestGroup = TestGroup("negTestFromBestEffortTasty")
3030
compileBestEffortTastyInDir(s"tests${JFile.separator}neg", bestEffortBaselineOptions,
3131
picklingFilter = FileFilter.exclude(TestSources.negBestEffortPicklingExcludelisted),
3232
unpicklingFilter = FileFilter.exclude(TestSources.negBestEffortUnpicklingExcludelisted)
3333
).checkNoCrash()
34-
}
3534

3635
// Tests an actual use case of this compilation mode, where symbol definitions of the downstream
3736
// projects depend on the best effort tasty files generated with the Best Effort dir option
38-
@Test def bestEffortIntergrationTest: Unit = {
39-
implicitvaltestGroup: TestGroup = TestGroup("bestEffortIntegrationTests")
37+
@Test def bestEffortIntegrationTest: Unit =
38+
given TestGroup = TestGroup("bestEffortIntegrationTests")
4039
compileBestEffortIntegration(s"tests${JFile.separator}best-effort", bestEffortBaselineOptions)
4140
.noCrashWithCompilingDependencies()
42-
}
4341
}
4442

4543
object BestEffortOptionsTests extends ParallelTesting {

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /