Commit 546fbd1

committed

Address review comments

1 parent 470be47 commit 546fbd1Copy full SHA for 546fbd1

File tree

-1

lines changed

compiler/src/dotty/tools
- backend/jvm
  - CodeGen.scala
- dotc/core
  - SymDenotations.scala

-1

lines changed

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -85,6 +85,7 @@ class CodeGen(val int: DottyBackendInterface, val primitives: DottyPrimitives)(`
`85`	`85`	`case ex: InterruptedException => throw ex`
`86`	`86`	`case ex: CompilationUnit.SuspendException => throw ex`
`87`	`87`	`case ex: Throwable =>`
	`88`	`+ if !ex.isInstanceOf[TypeError] then ex.printStackTrace()`
`88`	`89`	`report.error(s"Error while emitting ${unit.source}\n${ex.getMessage}", cd.sourcePos)`
`89`	`90`
`90`	`91`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -870,7 +870,7 @@ object SymDenotations {`
`870`	`870`	`def derivesFrom(base: Symbol)(using Context): Boolean = false`
`871`	`871`
`872`	`872`	/** Could `this` derive from `base` now or in the future.
`873`		`- * For concistency with derivesFrom, The info is only forced when this is a ClassDenotation.`
	`873`	`+ * For concistency with derivesFrom, the info is only forced when this is a ClassDenotation.`
`874`	`874`	`* If the info is a TempClassInfo then the baseClassSet may be temporarily approximated as empty.`
`875`	`875`	* This is problematic when stability of `!derivesFrom(base)` is assumed for soundness,
`876`	`876`	* e.g., in `TypeComparer#provablyDisjointClasses`.

Comments

(0)