-
Notifications
You must be signed in to change notification settings - Fork 131
-
In the same vein as scala/scala-xml#605, I was curious whether it was safe to override a scala-parser-combinators 1.x dependency with 2.x?
I ran MiMa between v1.1.2 and v2.1.1 and it reported the following errors:
* method map(scala.Function1)scala.util.parsing.combinator.Parsers#Success in class scala.util.parsing.combinator.Parsers#Success does not have a correspondent in current version
filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("scala.util.parsing.combinator.Parsers#Success.map")
* abstract synthetic method scala$util$parsing$combinator$RegexParsers$$super$err(java.lang.String)scala.util.parsing.combinator.Parsers#Parser in interface scala.util.parsing.combinator.RegexParsers is present only in current version
filter with: ProblemFilters.exclude[ReversedMissingMethodProblem]("scala.util.parsing.combinator.RegexParsers.scala$util$parsing$combinator$RegexParsers$$super$err")
* method this(Array[Char])Unit in class scala.util.parsing.input.CharArrayReader does not have a correspondent in current version
filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("scala.util.parsing.input.CharArrayReader.this")
* class scala.util.parsing.json.JSON does not have a correspondent in current version
filter with: ProblemFilters.exclude[MissingClassProblem]("scala.util.parsing.json.JSON")
* object scala.util.parsing.json.JSON does not have a correspondent in current version
filter with: ProblemFilters.exclude[MissingClassProblem]("scala.util.parsing.json.JSON$")
* class scala.util.parsing.json.JSONArray does not have a correspondent in current version
filter with: ProblemFilters.exclude[MissingClassProblem]("scala.util.parsing.json.JSONArray"
* object scala.util.parsing.json.JSONArray does not have a correspondent in current version
filter with: ProblemFilters.exclude[MissingClassProblem]("scala.util.parsing.json.JSONArray$")
* class scala.util.parsing.json.JSONFormat does not have a correspondent in current version
filter with: ProblemFilters.exclude[MissingClassProblem]("scala.util.parsing.json.JSONFormat")
* object scala.util.parsing.json.JSONFormat does not have a correspondent in current version
filter with: ProblemFilters.exclude[MissingClassProblem]("scala.util.parsing.json.JSONFormat$")
* class scala.util.parsing.json.JSONObject does not have a correspondent in current version
filter with: ProblemFilters.exclude[MissingClassProblem]("scala.util.parsing.json.JSONObject")
* object scala.util.parsing.json.JSONObject does not have a correspondent in current version
filter with: ProblemFilters.exclude[MissingClassProblem]("scala.util.parsing.json.JSONObject$")
* class scala.util.parsing.json.JSONType does not have a correspondent in current version
filter with: ProblemFilters.exclude[MissingClassProblem]("scala.util.parsing.json.JSONType")
* class scala.util.parsing.json.Lexer does not have a correspondent in current version
filter with: ProblemFilters.exclude[MissingClassProblem]("scala.util.parsing.json.Lexer")
* class scala.util.parsing.json.Parser does not have a correspondent in current version
filter with: ProblemFilters.exclude[MissingClassProblem]("scala.util.parsing.json.Parser")
* class scala.util.parsing.json.package does not have a correspondent in current version
filter with: ProblemFilters.exclude[MissingClassProblem]("scala.util.parsing.json.package")
* object scala.util.parsing.json.package does not have a correspondent in current version
filter with: ProblemFilters.exclude[MissingClassProblem]("scala.util.parsing.json.package$")
Beta Was this translation helpful? Give feedback.
All reactions
Replies: 2 comments
-
Ofcourse no guarantees, as it's a major upgrade. The main thing removed was json parsing in #227 which was deprecated long before it was removed.
Beta Was this translation helpful? Give feedback.
All reactions
-
Thank you for opening this discussion — good to have a single place we can collect experiences.
Personally, I have yet to hear of anyone having trouble in practice except from the obvious scala.util.parsing.json removal. (But of course mere absence of evidence is not conclusive.)
The CharArrayReader thing was discussed at scala/scala#9292 . It's certainly possible it could bite someone, but only if they're actually using CharArrayReader. Usage is rare but not unheard of.
Beta Was this translation helpful? Give feedback.