Commit f69f811

authored

Fix 'findExecutable...' bug for full-path spec (#35)

1 parent 0fff7d9 commit f69f811Copy full SHA for f69f811

File tree

-1

lines changed

src
- main/java/com/nordstrom/common/file
  - PathUtils.java
- test/java/com/nordstrom/common/file
  - PathUtilsTest.java

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -267,7 +267,7 @@ public String getNewName() {`
`267`	`267`	`*/`
`268`	`268`	`public static String findExecutableOnSystemPath(final String nameOrPath) {`
`269`	`269`	`List<String> paths = getSystemPathList();`
`270`		`- paths.add(0, "");`
	`270`	`+ paths.add(0, null); // check full path first`
`271`	`271`	`for (String path : paths) {`
`272`	`272`	`for (String ending : ENDINGS) {`
`273`	`273`	`File file = new File(path, nameOrPath + ending);`

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -146,6 +146,13 @@ public void testFindExecutableOnSystemPath() {`
`146`	`146`	`assertNotNull(path);`
`147`	`147`	`}`
`148`	`148`
	`149`	`+ @Test`
	`150`	`+ public void testFindExecutableByFullPath() {`
	`151`	`+ String javaPath = System.getProperty("java.home") + File.separator + "bin" + File.separator + "java";`
	`152`	`+ String path = PathUtils.findExecutableOnSystemPath(javaPath);`
	`153`	`+ assertNotNull(path);`
	`154`	`+ }`
	`155`	`+`
`149`	`156`	`@Test`
`150`	`157`	`public void testGetSystemPath() {`
`151`	`158`	`String systemPath = PathUtils.getSystemPath();`

Comments

(0)