Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Commit c93722f

Browse files
committed
Merge pull request #3 from georgekankava/staging/standard-outputs-should-not-be-used-directly-to-log-anything-fix-1
squid:S106 Standard outputs should not be used directly to log anything
2 parents e135472 + efc347b commit c93722f

File tree

3 files changed

+26
-17
lines changed

3 files changed

+26
-17
lines changed

‎src/main/java/org/sayem/webdriver/browsers/config/BrowserThreads.java

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
import org.openqa.selenium.remote.RemoteWebDriver;
1212
import org.sayem.webdriver.TestBase;
1313
import org.sayem.webdriver.properties.Repository;
14+
import org.slf4j.Logger;
1415

1516
import java.net.InetSocketAddress;
1617
import java.net.MalformedURLException;
@@ -19,12 +20,14 @@
1920
import static org.openqa.selenium.Proxy.ProxyType.MANUAL;
2021
import static org.sayem.webdriver.browsers.config.BrowserType.FIREFOX;
2122
import static org.sayem.webdriver.browsers.config.BrowserType.valueOf;
23+
import static org.slf4j.LoggerFactory.getLogger;
2224

2325
/**
2426
* Created by sayem on 10/05/15.
2527
*/
2628
public class BrowserThreads {
2729

30+
private static final Logger log = getLogger(BrowserThreads.class);
2831
private final String defaultUrl = System.getProperty("seleniumUrl");
2932
private final BrowserType defaultBrowserType = getBrowser();
3033
private final String browser = System.getProperty("browser", defaultBrowserType.toString()).toUpperCase();
@@ -97,19 +100,19 @@ private void determineEffectiveDriverType() {
97100
try {
98101
driverType = valueOf(browser);
99102
} catch (IllegalArgumentException ignored) {
100-
System.err.println("Unknown driver specified, defaulting to '" + driverType + "'...");
103+
log.error("Unknown driver specified, defaulting to '" + driverType + "'...");
101104
} catch (NullPointerException ignored) {
102-
System.err.println("No driver specified, defaulting to '" + driverType + "'...");
105+
log.error("No driver specified, defaulting to '" + driverType + "'...");
103106
}
104107
selectedDriverType = driverType;
105108
}
106109

107110
private void instantiateWebDriver(DesiredCapabilities desiredCapabilities) {
108-
System.out.println(" ");
109-
System.out.println("Current Operating System: " + operatingSystem);
110-
System.out.println("Current Architecture: " + systemArchitecture);
111-
System.out.println("Current Browser Selection: " + selectedDriverType);
112-
System.out.println(" ");
111+
log.info(" ");
112+
log.info("Current Operating System: " + operatingSystem);
113+
log.info("Current Architecture: " + systemArchitecture);
114+
log.info("Current Browser Selection: " + selectedDriverType);
115+
log.info(" ");
113116

114117
if (useRemoteWebDriver) {
115118
URL seleniumGridURL = null;
@@ -139,7 +142,7 @@ private void instantiateWebDriver(DesiredCapabilities desiredCapabilities) {
139142

140143
private void setup() {
141144
if (defaultUrl.isEmpty()) {
142-
System.err.println("No URL specified, defaulting to: " + defaultUrl + "'...");
145+
log.error("No URL specified, defaulting to: " + defaultUrl + "'...");
143146
webdriver.navigate().to(TestBase.getProperties(Repository.URL));
144147
}else {
145148
webdriver.navigate().to(defaultUrl);
@@ -151,9 +154,9 @@ private BrowserType getBrowser() {
151154
try {
152155
browserType = valueOf(TestBase.getProperties(Repository.BROWSER).toUpperCase());
153156
} catch (IllegalArgumentException ignored) {
154-
System.err.println("Unknown driver specified, defaulting to '" + browserType + "'...");
157+
log.error("Unknown driver specified, defaulting to '" + browserType + "'...");
155158
} catch (NullPointerException ignored) {
156-
System.err.println("No driver specified in property, defaulting to '" + browserType + "'...");
159+
log.error("No driver specified in property, defaulting to '" + browserType + "'...");
157160
}
158161
return browserType;
159162
}

‎src/main/java/org/sayem/webdriver/listeners/ScreenshotListener.java

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import org.openqa.selenium.TakesScreenshot;
55
import org.openqa.selenium.WebDriver;
66
import org.openqa.selenium.remote.Augmenter;
7+
import org.slf4j.Logger;
78
import org.testng.ITestResult;
89
import org.testng.TestListenerAdapter;
910

@@ -12,12 +13,15 @@
1213
import java.io.IOException;
1314

1415
import static org.sayem.webdriver.TestBase.driver;
16+
import static org.slf4j.LoggerFactory.getLogger;
1517

1618
/**
1719
* Created by sayem on 10/05/15.
1820
*/
1921
public class ScreenshotListener extends TestListenerAdapter {
2022

23+
private static final Logger log = getLogger(ScreenshotListener.class);
24+
2125
private boolean createFile(File screenshot) {
2226
boolean fileCreated = false;
2327

@@ -43,8 +47,7 @@ private void writeScreenshotToFile(WebDriver driver, File screenshot) {
4347
screenshotStream.write(((TakesScreenshot) driver).getScreenshotAs(OutputType.BYTES));
4448
screenshotStream.close();
4549
} catch (IOException unableToWriteScreenshot) {
46-
System.err.println("Unable to write " + screenshot.getAbsolutePath());
47-
unableToWriteScreenshot.printStackTrace();
50+
log.error("Unable to write " + screenshot.getAbsolutePath(), unableToWriteScreenshot);
4851
}
4952
}
5053

@@ -61,13 +64,12 @@ public void onTestFailure(ITestResult failingTest) {
6164
} catch (ClassCastException weNeedToAugmentOurDriverObject) {
6265
writeScreenshotToFile(new Augmenter().augment(driver), screenshot);
6366
}
64-
System.out.println("Written screenshot to " + screenshotAbsolutePath);
67+
log.info("Written screenshot to " + screenshotAbsolutePath);
6568
} else {
66-
System.err.println("Unable to create " + screenshotAbsolutePath);
69+
log.error("Unable to create " + screenshotAbsolutePath);
6770
}
6871
} catch (Exception ex) {
69-
System.err.println("Unable to capture screenshot...");
70-
ex.printStackTrace();
72+
log.error("Unable to capture screenshot...", ex);
7173
}
7274
}
7375
}

‎src/main/java/org/sayem/webdriver/listeners/TestNGRetry.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,19 +2,23 @@
22

33
import org.testng.IRetryAnalyzer;
44
import org.testng.ITestResult;
5+
import org.slf4j.Logger;
6+
7+
import static org.slf4j.LoggerFactory.getLogger;
58

69
/**
710
* Created by sayem on 2/2/16.
811
*/
912
public class TestNGRetry implements IRetryAnalyzer {
13+
private static final Logger log = getLogger(TestNGRetry.class);
1014
private int retryCount = 0;
1115
private int maxRetryCount = 1;
1216

1317
// Below method returns 'true' if the test method has to be retried else 'false'
1418
// and it takes the 'Result' as parameter of the test method that just ran
1519
public boolean retry(ITestResult result) {
1620
if (retryCount < maxRetryCount) {
17-
System.out.println("Retrying test " + result.getName() + " with status "
21+
log.info("Retrying test " + result.getName() + " with status "
1822
+ getResultStatusName(result.getStatus()) + " for the " + (retryCount+1) + " time(s).");
1923
retryCount++;
2024
return true;

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /