Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Commit b77b8a6

Browse files
squid:S106 Standard outputs should not be used directly to log anything
1 parent e46309c commit b77b8a6

File tree

3 files changed

+29
-15
lines changed

3 files changed

+29
-15
lines changed

‎src/main/java/org/sayem/webdriver/browsers/config/BrowserThreads.java

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
import org.openqa.selenium.remote.RemoteWebDriver;
1212
import org.sayem.webdriver.TestBase;
1313
import org.sayem.webdriver.properties.Repository;
14+
import org.slf4j.Logger;
1415

1516
import java.net.InetSocketAddress;
1617
import java.net.MalformedURLException;
@@ -20,11 +21,14 @@
2021
import static org.sayem.webdriver.browsers.config.BrowserType.FIREFOX;
2122
import static org.sayem.webdriver.browsers.config.BrowserType.valueOf;
2223

24+
import static org.slf4j.LoggerFactory.getLogger;
25+
2326
/**
2427
* Created by sayem on 10/05/15.
2528
*/
2629
public class BrowserThreads {
2730

31+
private static final Logger log = getLogger(BrowserThreads.class);
2832
private final String defaultUrl = System.getProperty("seleniumUrl");
2933
private final BrowserType defaultBrowserType = getBrowser();
3034
private final String browser = System.getProperty("browser", defaultBrowserType.toString()).toUpperCase();
@@ -97,19 +101,19 @@ private void determineEffectiveDriverType() {
97101
try {
98102
driverType = valueOf(browser);
99103
} catch (IllegalArgumentException ignored) {
100-
System.err.println("Unknown driver specified, defaulting to '" + driverType + "'...");
104+
log.error("Unknown driver specified, defaulting to '" + driverType + "'...");
101105
} catch (NullPointerException ignored) {
102-
System.err.println("No driver specified, defaulting to '" + driverType + "'...");
106+
log.error("No driver specified, defaulting to '" + driverType + "'...");
103107
}
104108
selectedDriverType = driverType;
105109
}
106110

107111
private void instantiateWebDriver(DesiredCapabilities desiredCapabilities) {
108-
System.out.println(" ");
109-
System.out.println("Current Operating System: " + operatingSystem);
110-
System.out.println("Current Architecture: " + systemArchitecture);
111-
System.out.println("Current Browser Selection: " + selectedDriverType);
112-
System.out.println(" ");
112+
log.info(" ");
113+
log.info("Current Operating System: " + operatingSystem);
114+
log.info("Current Architecture: " + systemArchitecture);
115+
log.info("Current Browser Selection: " + selectedDriverType);
116+
log.info(" ");
113117

114118
if (useRemoteWebDriver) {
115119
URL seleniumGridURL = null;
@@ -139,7 +143,7 @@ private void instantiateWebDriver(DesiredCapabilities desiredCapabilities) {
139143

140144
private void setup() {
141145
if (defaultUrl.isEmpty()) {
142-
System.err.println("No URL specified, defaulting to: " + defaultUrl + "'...");
146+
log.error("No URL specified, defaulting to: " + defaultUrl + "'...");
143147
webdriver.navigate().to(TestBase.getProperties(Repository.URL));
144148
}else {
145149
webdriver.navigate().to(defaultUrl);
@@ -151,9 +155,9 @@ private BrowserType getBrowser() {
151155
try {
152156
browserType = valueOf(TestBase.getProperties(Repository.BROWSER).toUpperCase());
153157
} catch (IllegalArgumentException ignored) {
154-
System.err.println("Unknown driver specified, defaulting to '" + browserType + "'...");
158+
log.error("Unknown driver specified, defaulting to '" + browserType + "'...");
155159
} catch (NullPointerException ignored) {
156-
System.err.println("No driver specified in property, defaulting to '" + browserType + "'...");
160+
log.error("No driver specified in property, defaulting to '" + browserType + "'...");
157161
}
158162
return browserType;
159163
}

‎src/main/java/org/sayem/webdriver/listeners/ScreenshotListener.java

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import org.openqa.selenium.TakesScreenshot;
55
import org.openqa.selenium.WebDriver;
66
import org.openqa.selenium.remote.Augmenter;
7+
import org.slf4j.Logger;
78
import org.testng.ITestResult;
89
import org.testng.TestListenerAdapter;
910

@@ -13,11 +14,15 @@
1314

1415
import static org.sayem.webdriver.TestBase.driver;
1516

17+
import static org.slf4j.LoggerFactory.getLogger;
18+
1619
/**
1720
* Created by sayem on 10/05/15.
1821
*/
1922
public class ScreenshotListener extends TestListenerAdapter {
2023

24+
private static final Logger log = getLogger(ScreenshotListener.class);
25+
2126
private boolean createFile(File screenshot) {
2227
boolean fileCreated = false;
2328

@@ -43,7 +48,7 @@ private void writeScreenshotToFile(WebDriver driver, File screenshot) {
4348
screenshotStream.write(((TakesScreenshot) driver).getScreenshotAs(OutputType.BYTES));
4449
screenshotStream.close();
4550
} catch (IOException unableToWriteScreenshot) {
46-
System.err.println("Unable to write " + screenshot.getAbsolutePath());
51+
log.error("Unable to write " + screenshot.getAbsolutePath(), unableToWriteScreenshot);
4752
unableToWriteScreenshot.printStackTrace();
4853
}
4954
}
@@ -61,12 +66,12 @@ public void onTestFailure(ITestResult failingTest) {
6166
} catch (ClassCastException weNeedToAugmentOurDriverObject) {
6267
writeScreenshotToFile(new Augmenter().augment(driver), screenshot);
6368
}
64-
System.out.println("Written screenshot to " + screenshotAbsolutePath);
69+
log.info("Written screenshot to " + screenshotAbsolutePath);
6570
} else {
66-
System.err.println("Unable to create " + screenshotAbsolutePath);
71+
log.error("Unable to create " + screenshotAbsolutePath);
6772
}
6873
} catch (Exception ex) {
69-
System.err.println("Unable to capture screenshot...");
74+
log.error("Unable to capture screenshot...", ex);
7075
ex.printStackTrace();
7176
}
7277
}

‎src/main/java/org/sayem/webdriver/listeners/TestNGRetry.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,18 +3,23 @@
33
import org.testng.IRetryAnalyzer;
44
import org.testng.ITestResult;
55

6+
import static org.slf4j.LoggerFactory.getLogger;
7+
8+
import org.slf4j.Logger;
9+
610
/**
711
* Created by sayem on 2/2/16.
812
*/
913
public class TestNGRetry implements IRetryAnalyzer {
14+
private static final Logger log = getLogger(TestNGRetry.class);
1015
private int retryCount = 0;
1116
private int maxRetryCount = 1;
1217

1318
// Below method returns 'true' if the test method has to be retried else 'false'
1419
// and it takes the 'Result' as parameter of the test method that just ran
1520
public boolean retry(ITestResult result) {
1621
if (retryCount < maxRetryCount) {
17-
System.out.println("Retrying test " + result.getName() + " with status "
22+
log.info("Retrying test " + result.getName() + " with status "
1823
+ getResultStatusName(result.getStatus()) + " for the " + (retryCount+1) + " time(s).");
1924
retryCount++;
2025
return true;

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /