Commit 58a3dd8

committed

Refactor BrokenImageTest

1 parent 1f4bebc commit 58a3dd8Copy full SHA for 58a3dd8

File tree

2 files changed

-34

lines changed

src/test/java/org/sayem/webdriver
- pages/internet
  - BrokenImagePage.java
- testcases/internet
  - BrokenImageTest.java

2 files changed

-34

lines changed

`‎src/test/java/org/sayem/webdriver/pages/internet/BrokenImagePage.java`

Lines changed: 8 additions & 26 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,14 +1,10 @@`
`1`	`1`	`package org.sayem.webdriver.pages.internet;`
`2`	`2`
`3`	`3`	`import com.jayway.restassured.response.Response;`
`4`		`-import org.openqa.selenium.By;`
`5`	`4`	`import org.openqa.selenium.WebDriver;`
`6`		`-import org.openqa.selenium.WebElement;`
`7`	`5`	`import org.sayem.webdriver.selectors.CssSelector;`
`8`	`6`	`import org.sayem.webdriver.selenium.Browser;`
`9`	`7`
`10`		`-import java.util.List;`
`11`		`-`
`12`	`8`	`import static com.jayway.restassured.RestAssured.given;`
`13`	`9`
`14`	`10`	`/**`
`@@ -24,29 +20,15 @@ public BrokenImagePage(WebDriver driver) {`
`24`	`20`	`}`
`25`	`21`
`26`	`22`	`public BrokenImagePage brokenImage() {`
`27`		`- Stringimage = browser.findElements(CssSelector.BROKEN_IMAGE)`
	`23`	`+ browser.findElements(CssSelector.BROKEN_IMAGE)`
`28`	`24`	`.map(s -> s.getAttribute("src"))`
`29`		`- .findFirst().get();`
`30`		`-`
`31`		`- response = given().get(image).then().extract().response();`
`32`		`- if (200 != response.getStatusCode()) {`
`33`		`- System.out.println(image + " gave a response code of " + response.getStatusCode());`
`34`		`- }`
`35`		`- return this;`
`36`		`- }`
`37`		`-`
`38`		`- public BrokenImagePage brokenImages() {`
`39`		`- List<WebElement> links = browser.findElements(By.cssSelector(".example>img"));`
`40`		`- String jpg;`
`41`		`-`
`42`		`- for (WebElement link : links) {`
`43`		`- jpg = link.getAttribute("src");`
`44`		`- response = given().get(jpg).then().extract().response();`
`45`		`-`
`46`		`- if (200 != response.getStatusCode()) {`
`47`		`- System.out.println(jpg + " gave a response code of " + response.getStatusCode());`
`48`		`- }`
`49`		`- }`
	`25`	`+ .forEach(s -> {`
	`26`	`+ response = given().get(s).then().extract().response();`
	`27`	`+ if (200 != response.getStatusCode()) {`
	`28`	`+ System.out.println(s + " gave a response code of "`
	`29`	`+ + response.getStatusCode());`
	`30`	`+ }`
	`31`	`+ });`
`50`	`32`	`return this;`
`51`	`33`	`}`
`52`	`34`	`}`

`‎src/test/java/org/sayem/webdriver/testcases/internet/BrokenImageTest.java`

Lines changed: 0 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -16,12 +16,4 @@ public void brokenImageTest(){`
`16`	`16`	`page.brokenImage()`
`17`	`17`	`.brokenImage();`
`18`	`18`	`}`
`19`		`-`
`20`		`- @Test`
`21`		`- public void brokenImagesTest(){`
`22`		`- System.setProperty("seleniumUrl", "http://the-internet.herokuapp.com/");`
`23`		`- HomePage page = pageFactory(HomePage.class);`
`24`		`- page.brokenImage()`
`25`		`- .brokenImages();`
`26`		`- }`
`27`	`19`	`}`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 58a3dd8

File tree

2 files changed

2 files changed

`‎src/test/java/org/sayem/webdriver/pages/internet/BrokenImagePage.java`

`‎src/test/java/org/sayem/webdriver/testcases/internet/BrokenImageTest.java`

0 commit comments