Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Commit 0b9b5e7

Browse files
squid:S1148 Throwable.printStackTrace(...) should not be called
1 parent e46309c commit 0b9b5e7

File tree

5 files changed

+25
-8
lines changed

5 files changed

+25
-8
lines changed

‎src/main/java/org/sayem/webdriver/algorithm/Retry.java

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,17 @@
22

33
import java.util.concurrent.TimeUnit;
44

5+
import org.slf4j.Logger;
6+
7+
import static org.slf4j.LoggerFactory.getLogger;
8+
59
/**
610
* Created by sayem on 10/05/15.
711
*/
812
@SuppressWarnings("Duplicates")
913
public class Retry {
1014

15+
private static final Logger log = getLogger(Retry.class);
1116
private final long interval;
1217
private final TimeUnit unit;
1318
private boolean on;
@@ -76,7 +81,7 @@ private <T> T perform(Attemptable<T> task) throws Exception {
7681
return attempt;
7782
} catch (Exception e) {
7883
on();
79-
e.printStackTrace();
84+
log.error("Exception while execution", e);
8085
if (count == 0) {
8186
throw e;
8287
}
@@ -92,7 +97,7 @@ private void rest() {
9297
try {
9398
unit.sleep(interval);
9499
} catch (InterruptedException e) {
95-
e.printStackTrace();
100+
log.error("Thread has been interrupted", e);
96101
}
97102
}
98103

‎src/main/java/org/sayem/webdriver/browsers/config/BrowserThreads.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
import org.openqa.selenium.remote.RemoteWebDriver;
1212
import org.sayem.webdriver.TestBase;
1313
import org.sayem.webdriver.properties.Repository;
14+
import org.slf4j.Logger;
1415

1516
import java.net.InetSocketAddress;
1617
import java.net.MalformedURLException;
@@ -19,12 +20,14 @@
1920
import static org.openqa.selenium.Proxy.ProxyType.MANUAL;
2021
import static org.sayem.webdriver.browsers.config.BrowserType.FIREFOX;
2122
import static org.sayem.webdriver.browsers.config.BrowserType.valueOf;
23+
import static org.slf4j.LoggerFactory.getLogger;
2224

2325
/**
2426
* Created by sayem on 10/05/15.
2527
*/
2628
public class BrowserThreads {
2729

30+
private static final Logger log = getLogger(BrowserThreads.class);
2831
private final String defaultUrl = System.getProperty("seleniumUrl");
2932
private final BrowserType defaultBrowserType = getBrowser();
3033
private final String browser = System.getProperty("browser", defaultBrowserType.toString()).toUpperCase();
@@ -116,7 +119,7 @@ private void instantiateWebDriver(DesiredCapabilities desiredCapabilities) {
116119
try {
117120
seleniumGridURL = new URL(System.getProperty("gridURL"));
118121
} catch (MalformedURLException e) {
119-
e.printStackTrace();
122+
log.error("Either no legal protocol could be found or the string could not be parsed.", e);
120123
}
121124
String desiredBrowserVersion = System.getProperty("desiredBrowserVersion");
122125
String desiredPlatform = System.getProperty("desiredPlatform");

‎src/main/java/org/sayem/webdriver/listeners/ScreenshotListener.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import org.openqa.selenium.TakesScreenshot;
55
import org.openqa.selenium.WebDriver;
66
import org.openqa.selenium.remote.Augmenter;
7+
import org.slf4j.Logger;
78
import org.testng.ITestResult;
89
import org.testng.TestListenerAdapter;
910

@@ -12,12 +13,15 @@
1213
import java.io.IOException;
1314

1415
import static org.sayem.webdriver.TestBase.driver;
16+
import static org.slf4j.LoggerFactory.getLogger;
1517

1618
/**
1719
* Created by sayem on 10/05/15.
1820
*/
1921
public class ScreenshotListener extends TestListenerAdapter {
2022

23+
private static final Logger log = getLogger(ScreenshotListener.class);
24+
2125
private boolean createFile(File screenshot) {
2226
boolean fileCreated = false;
2327

@@ -29,7 +33,7 @@ private boolean createFile(File screenshot) {
2933
try {
3034
fileCreated = screenshot.createNewFile();
3135
} catch (IOException errorCreatingScreenshot) {
32-
errorCreatingScreenshot.printStackTrace();
36+
log.error("failed or interrupted I/O operations", errorCreatingScreenshot);
3337
}
3438
}
3539
}

‎src/main/java/org/sayem/webdriver/properties/PropertiesUtil.java

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,19 @@
11
package org.sayem.webdriver.properties;
22

3+
import static org.slf4j.LoggerFactory.getLogger;
4+
35
import java.io.FileInputStream;
46
import java.io.IOException;
57
import java.lang.reflect.InvocationTargetException;
68
import java.util.Properties;
79

10+
import org.slf4j.Logger;
11+
812
/**
913
* Created by sayem on 12/28/15.
1014
*/
1115
public class PropertiesUtil {
16+
private static final Logger log = getLogger(PropertiesUtil.class);
1217
private String dataLocation;
1318
private Properties properties;
1419

@@ -44,7 +49,7 @@ private void loadProperties() {
4449
properties = new Properties();
4550
properties.load(fileInputStream);
4651
} catch (IOException e) {
47-
e.printStackTrace();
52+
log.error("failed or interrupted I/O operations", e);;
4853
}
4954
}
5055

@@ -55,7 +60,7 @@ public String getProperties(String name) {
5560
prop = properties.getProperty(name);
5661

5762
} catch (Exception e) {
58-
e.printStackTrace();
63+
log.error("Exception while execution", e);
5964
}
6065
return prop;
6166
}
@@ -68,7 +73,7 @@ public <T> T getProperties(String name, Class<T> type) {
6873
prop = valueOf(type, temp);
6974

7075
} catch (Exception e) {
71-
e.printStackTrace();
76+
log.error("Exception while execution", e);
7277
}
7378
return prop;
7479
}

‎src/main/java/org/sayem/webdriver/selenium/Browser.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ public void delayFor(int millis) {
120120
try {
121121
Thread.sleep(millis);
122122
} catch (InterruptedException e) {
123-
e.printStackTrace();
123+
log.error("Thread has been interrupted", e);
124124
}
125125
}
126126

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /