Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit f6096ba

Browse files
Merge pull request testing-library#526 from testing-library/bugfix/beta-pure-typeerror
fix: ReactHooksRenderer renderHook was not expecting arguments
2 parents a3fd0e2 + 9bab184 commit f6096ba

File tree

3 files changed

+10
-7
lines changed

3 files changed

+10
-7
lines changed

‎src/core/index.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
import { CreateRenderer, Renderer, RenderResult, RenderHook } from '../types'
2-
import { ResultContainer,RenderHookOptions } from '../types/internal'
1+
import { CreateRenderer, Renderer, RenderResult, RenderHook,RenderHookOptions } from '../types'
2+
import { ResultContainer } from '../types/internal'
33

44
import asyncUtils from './asyncUtils'
55
import { cleanup, addCleanup, removeCleanup } from './cleanup'

‎src/types/index.ts‎

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,13 +48,20 @@ export type RenderHook<
4848
AsyncUtils
4949

5050
export interface ReactHooksRenderer {
51-
renderHook: <TProps, TResult>() => RenderHook<TProps, TResult>
51+
renderHook: <TProps, TResult, TOptions>(
52+
callback: (props: TProps) => TResult,
53+
options?: RenderHookOptions<TProps, TOptions>
54+
) => RenderHook<TProps, TResult>
5255
act: Act
5356
cleanup: () => void
5457
addCleanup: (callback: () => Promise<void> | void) => () => void
5558
removeCleanup: (callback: () => Promise<void> | void) => void
5659
}
5760

61+
export type RenderHookOptions<TProps, TOptions extends {}> = TOptions & {
62+
initialProps?: TProps
63+
}
64+
5865
export interface Act {
5966
(callback: () => void | undefined): void
6067
(callback: () => Promise<void | undefined>): Promise<undefined>

‎src/types/internal.ts‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,3 @@ export type ResultContainer<TValue> = {
66
setValue: (val: TValue) => void
77
setError: (error: Error) => void
88
}
9-
10-
export type RenderHookOptions<TProps, TOptions extends {}> = TOptions & {
11-
initialProps?: TProps
12-
}

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /