Commit 1863e29

phip1611nicholasbishop

authored and

committed

Transform feature "ignore-logger-errors" to additive feature.

1 parent 9047806 commit 1863e29Copy full SHA for 1863e29

File tree

+11

-8

lines changed

+11

-8

lines changed

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,8 @@`
`22`	`22`	- Deprecated `BootServices::locate_protocol` and marked it `unsafe`. Use
`23`	`23`	`BootServices::get_handle_for_protocol` and
`24`	`24`	`BootServices::open_protocol` instead.
	`25`	+- renamed feature `ignore-logger-errors` to `panic-on-logger-errors` so that it is
	`26`	`+ additive. It is now a default feature.`
`25`	`27`
`26`	`28`	`### Removed`
`27`	`29`
`@@ -39,7 +41,7 @@`
`39`	`41`
`40`	`42`	- The `no_panic_handler` feature has been replaced with an additive
`41`	`43`	`panic_handler` feature. The new feature is enabled by default.
`42`		`-`
	`44`	`+`
`43`	`45`	`## uefi - 0.16.1`
`44`	`46`
`45`	`47`	`### Added`
`@@ -55,7 +57,7 @@`
`55`	`57`	`function pointers. This prevents potential invalid pointer access.`
`56`	`58`	- Fixed an incorrect pointer cast in the `Rng` protocol that could cause
`57`	`59`	`undefined behavior.`
`58`		`-`
	`60`	`+`
`59`	`61`	`### Changed`
`60`	`62`
`61`	`63`	- Relaxed the version requirements for the `bitflags` and `log`

Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -19,13 +19,14 @@ categories = ["embedded", "no-std", "api-bindings"]`
`19`	`19`	`license = "MPL-2.0"`
`20`	`20`
`21`	`21`	`[features]`
`22`		`-default = []`
	`22`	`+default = ["panic-on-logger-errors"]`
`23`	`23`	`alloc = []`
`24`	`24`	`exts = []`
`25`	`25`	`logger = []`
`26`	`26`	`# Ignore text output errors in logger as a workaround for firmware issues that`
`27`		`-# were observed on the VirtualBox UEFI implementation (see uefi-rs#121)`
`28`		`-ignore-logger-errors = []`
	`27`	`+# were observed on the VirtualBox UEFI implementation (see uefi-rs#121).`
	`28`	`+# In those cases, this feature can be excluded by removing the default features.`
	`29`	`+panic-on-logger-errors = []`
`29`	`30`
`30`	`31`	`[dependencies]`
`31`	`32`	`bitflags = "1.3.1"`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -73,11 +73,11 @@ impl log::Log for Logger {`
`73`	`73`	`// Ignoring errors is bad, especially when they represent loss of`
`74`	`74`	`// precious early-boot system diagnosis data, so we panic by`
`75`	`75`	`// default. But if you experience this problem and want your UEFI`
`76`		`- // application to keep running when it happens, you can enable the`
`77`		- // `ignore-logger-error` cargo feature. If you do so, logging errors
	`76`	`+ // application to keep running when it happens, you can disable the`
	`77`	+ // `panic-on-logger-errors` cargo feature. If you do so, logging errors
`78`	`78`	// will be ignored by `uefi-rs` instead.
`79`	`79`	`//`
`80`		`- if !cfg!(feature = "ignore-logger-errors") {`
	`80`	`+ if cfg!(feature = "panic-on-logger-errors") {`
`81`	`81`	`result.unwrap()`
`82`	`82`	`}`
`83`	`83`	`}`

Comments

(0)