Commit 055cc9d

authored

Fixes #121: ignore EFI_DEVICE_ERROR in output_string (#122)

* Fixes #121: ignore EFI_DEVICE_ERROR in output_string Signed-off-by: imtsuki <me@qjx.app> * ignore Result in logger rather than Output protocol Signed-off-by: imtsuki <me@qjx.app> * Add a FIXME comment that we are ignoring logger's `Result` Signed-off-by: imtsuki <me@qjx.app>

1 parent 006c388 commit 055cc9dCopy full SHA for 055cc9d

File tree

1 file changed

-1

lines changed

src
- logger.rs

1 file changed

-1

lines changed

`‎src/logger.rs`

Lines changed: 7 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,13 @@ impl<'boot> log::Log for Logger {`
`56`	`56`	`fn log(&self, record: &log::Record) {`
`57`	`57`	`if let Some(mut ptr) = self.writer {`
`58`	`58`	`let writer = unsafe { ptr.as_mut() };`
`59`		`- DecoratedLog::write(writer, record.level(), record.args()).unwrap();`
	`59`	`+ // FIXME: Some UEFI firmware implementations e.g. VrtualBox's implementation`
	`60`	`+ // occasionally report a EFI_DEVICE_ERROR with some text dropped out within`
	`61`	`+ // SimpleTextOutput protocol, which is a firmware bug. In that case, we will`
	`62`	+ // get a `fmt::Error` here. Since the `log` crate gives no other option to
	`63`	+ // deal with output errors, we ignore the `Result` here to prevent potential
	`64`	`+ // panics from happening.`
	`65`	`+ DecoratedLog::write(writer, record.level(), record.args()).unwrap_or_default();`
`60`	`66`	`}`
`61`	`67`	`}`
`62`	`68`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit 055cc9d

File tree

1 file changed

1 file changed

`‎src/logger.rs`

0 commit comments