Commit 0551959

HadrienG2GabrielMajeri

authored and

committed

Mark EFI status codes as must_use and check them

1 parent 47963af commit 0551959Copy full SHA for 0551959

File tree

-3

lines changed

-3

lines changed

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,7 @@ const HIGHEST_BIT_SET: usize = !((!0_usize) >> 1);`
`11`	`11`	`/// to indicate whether an operation completed successfully.`
`12`	`12`	`#[derive(Debug, Copy, Clone, Eq, PartialEq)]`
`13`	`13`	`#[repr(usize)]`
	`14`	`+#[must_use]`
`14`	`15`	`pub enum Status {`
`15`	`16`	`/// The operation completed successfully.`
`16`	`17`	`Success,`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,8 @@ impl BootServices {`
`101`	`101`	`let mut entry_size = 0;`
`102`	`102`	`let mut entry_version = 0;`
`103`	`103`
`104`		`- (self.memory_map)(&mut map_size, 0, &mut map_key, &mut entry_size, &mut entry_version);`
	`104`	`+ let status = (self.memory_map)(&mut map_size, 0, &mut map_key, &mut entry_size, &mut entry_version);`
	`105`	`+ assert_eq!(status, Status::BufferTooSmall);`
`105`	`106`
`106`	`107`	`map_size * entry_size`
`107`	`108`	`}`
`@@ -210,8 +211,7 @@ impl BootServices {`
`210`	`211`	`///`
`211`	`212`	`/// The time is in microseconds.`
`212`	`213`	`pub fn stall(&self, time: usize) {`
`213`		`- // The spec says this cannot fail.`
`214`		`- (self.stall)(time);`
	`214`	`+ assert_eq!((self.stall)(time), Status::Success);`
`215`	`215`	`}`
`216`	`216`
`217`	`217`	`/// Copies memory from source to destination. The buffers can overlap.`

Comments

(0)