Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Improve contributing text about subtrees #1672

Open
Labels
A-metaArea: meta, about rustc or rustc-dev-guide itself E-mediumDifficulty: might require some prior knowledge or code reading I-confusingIssue: info is confusing to readers T-bootstrapRelevant to bootstrap team T-compilerRelevant to compiler team
@jsoref

Description

https://rustc-dev-guide.rust-lang.org/contributing.html is really unhelpful.

There's a link for "External Dependencies", but:

  1. I wouldn't guess that it'd mean "things we have embedded in our repository but should be treated as external dependencies"
  2. it's just a link to https://rustc-dev-guide.rust-lang.org/external-repos.html

Beyond that, the final page doesn't actually answer my question of "where/how should changes be contributed".

The answer apparently being "In general such changes should be sent to the external repositories even if you find the code in /rust, unless you're making some other change to /rust and doing so would break those files, in which case your commit should include the fixes to them".

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-metaArea: meta, about rustc or rustc-dev-guide itself E-mediumDifficulty: might require some prior knowledge or code reading I-confusingIssue: info is confusing to readers T-bootstrapRelevant to bootstrap team T-compilerRelevant to compiler team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

        AltStyle によって変換されたページ (->オリジナル) /