Commit 42a3530

committed

Auto merge of #143958 - samueltardieu:rollup-lh1s143, r=samueltardieu

Rollup of 13 pull requests Successful merges: - rust-lang/rust#142301 (tests: Fix duplicated-path-in-error fail with musl) - rust-lang/rust#143630 (Drop `./x suggest`) - rust-lang/rust#143736 (Give all bytes of TypeId provenance) - rust-lang/rust#143752 (Don't panic if WASI_SDK_PATH not set when detecting compiler) - rust-lang/rust#143837 (Adjust `run_make_support::symbols` helpers) - rust-lang/rust#143878 (Port `#[pointee]` to the new attribute parsing infrastructure) - rust-lang/rust#143905 (Recover and suggest to use `;` to construct array type) - rust-lang/rust#143907 (core: make `str::split_at_unchecked()` inline) - rust-lang/rust#143910 (Add experimental `backtrace-trace-only` std feature) - rust-lang/rust#143927 (Preserve constness in trait objects up to hir ty lowering) - rust-lang/rust#143935 (rustc_type_ir/walk: move docstring to `TypeWalker` itself) - rust-lang/rust#143938 (Update books) - rust-lang/rust#143941 (update `cfg_select!` documentation) Failed merges: - rust-lang/rust#143926 (Remove deprecated fields in bootstrap) r? `@ghost` `@rustbot` modify labels: rollup

2 parents c786ff0 + 20c245b commit 42a3530Copy full SHA for 42a3530

File tree

4 files changed

-80

lines changed

src
- SUMMARY.md
- building
  - quickstart.md
  - suggested.md
- tests
  - suggest-tests.md

4 files changed

-80

lines changed

`‎src/SUMMARY.md‎`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,6 @@`
`35`	`35`	`- [Cranelift codegen backend](./tests/codegen-backend-tests/cg_clif.md)`
`36`	`36`	`- [GCC codegen backend](./tests/codegen-backend-tests/cg_gcc.md)`
`37`	`37`	`- [Performance testing](./tests/perf.md)`
`38`		`- - [Suggest tests tool](./tests/suggest-tests.md)`
`39`	`38`	`- [Misc info](./tests/misc.md)`
`40`	`39`	`- [Debugging the compiler](./compiler-debugging.md)`
`41`	`40`	`- [Using the tracing/logging instrumentation](./tracing.md)`

`‎src/building/quickstart.md‎`

Lines changed: 0 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -61,9 +61,6 @@ and check the output.`
`61`	`61`	Use `--bless` if you've made a change and want to update the `.stderr` files
`62`	`62`	`with the new output.`
`63`	`63`
`64`		-> `./x suggest` can also be helpful for suggesting which tests to run after a
`65`		`-> change.`
`66`		`-`
`67`	`64`	`Congrats, you are now ready to make a change to the compiler! If you have more`
`68`	`65`	`questions, [the full chapter](./how-to-build-and-run.md) might contain the`
`69`	`66`	`answers, and if it doesn't, feel free to ask for help on`

`‎src/building/suggested.md‎`

Lines changed: 0 additions & 17 deletions

Original file line number	Diff line number	Diff line change
@@ -270,23 +270,6 @@ run the tests at some later time. You can then use `git bisect` to track down
`270`	`270`	`is that you are left with a fairly fine-grained set of commits at the end, all`
`271`	`271`	`of which build and pass tests. This often helps reviewing.`
`272`	`272`
`273`		-## `x suggest`
`274`		`-`
`275`		-The `x suggest` subcommand suggests (and runs) a subset of the extensive
`276`		-`rust-lang/rust` tests based on files you have changed. This is especially
`277`		-useful for new contributors who have not mastered the arcane `x` flags yet and
`278`		`-more experienced contributors as a shorthand for reducing mental effort. In all`
`279`		`-cases it is useful not to run the full tests (which can take on the order of`
`280`		`-tens of minutes) and just run a subset which are relevant to your changes. For`
`281`		-example, running `tidy` and `linkchecker` is useful when editing Markdown files,
`282`		-whereas UI tests are much less likely to be helpful. While `x suggest` is a
`283`		`-useful tool, it does not guarantee perfect coverage (just as PR CI isn't a`
`284`		`-substitute for bors). See the [dedicated chapter](../tests/suggest-tests.md) for`
`285`		`-more information and contribution instructions.`
`286`		`-`
`287`		-Please note that `x suggest` is in a beta state currently and the tests that it
`288`		`-will suggest are limited.`
`289`		`-`
`290`	`273`	## Configuring `rustup` to use nightly
`291`	`274`
`292`	`275`	`Some parts of the bootstrap process uses pinned, nightly versions of tools like`

`‎src/tests/suggest-tests.md‎`

Lines changed: 0 additions & 59 deletions

This file was deleted.

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 42a3530

File tree

4 files changed

4 files changed

`‎src/SUMMARY.md‎`

`‎src/building/quickstart.md‎`

`‎src/building/suggested.md‎`

`‎src/tests/suggest-tests.md‎`

0 commit comments