Commit f51ce75

authored

Rollup merge of #123516 - estebank:issue-123428, r=compiler-errors

Do not ICE on field access check on expr with `ty::Error` Fix #123428

2 parents 84dca15 + 97ea48c commit f51ce75Copy full SHA for f51ce75

File tree

+28

-1

lines changed

+28

-1

lines changed

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -153,7 +153,8 @@ impl<'tcx> MarkSymbolVisitor<'tcx> {`
`153`	`153`	`self.insert_def_id(def.non_enum_variant().fields[index].did);`
`154`	`154`	`}`
`155`	`155`	`ty::Tuple(..) => {}`
`156`		`- _ => span_bug!(lhs.span, "named field access on non-ADT"),`
	`156`	`+ ty::Error(_) => {}`
	`157`	`+ kind => span_bug!(lhs.span, "named field access on non-ADT: {kind:?}"),`
`157`	`158`	`}`
`158`	`159`	`}`
`159`	`160`

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,9 @@`
	`1`	`+trait Foo {}`
	`2`	`+impl<T> Foo for T {}`
	`3`	`+`
	`4`	`+fn main() {`
	`5`	`+ let array = [(); { loop {} }]; //~ ERROR constant evaluation is taking a long time`
	`6`	`+`
	`7`	`+ let tup = (7,);`
	`8`	`+ let x: &dyn Foo = &tup.0;`
	`9`	`+}`

Lines changed: 17 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,17 @@`
	`1`	`+error: constant evaluation is taking a long time`
	`2`	`+ --> $DIR/do-not-ice-on-field-access-of-err-type.rs:5:24`
	`3`	`+ \|`
	`4`	`+LL \| let array = [(); { loop {} }];`
	`5`	`+ \| ^^^^^^^`
	`6`	`+ \|`
	`7`	`+ = note: this lint makes sure the compiler doesn't get stuck due to infinite loops in const eval.`
	`8`	`+ If your compilation actually takes a long time, you can safely allow the lint.`
	`9`	`+help: the constant being evaluated`
	`10`	`+ --> $DIR/do-not-ice-on-field-access-of-err-type.rs:5:22`
	`11`	`+ \|`
	`12`	`+LL \| let array = [(); { loop {} }];`
	`13`	`+ \| ^^^^^^^^^^^`
	`14`	+ = note: `#[deny(long_running_const_eval)]` on by default
	`15`	`+`
	`16`	`+error: aborting due to 1 previous error`
	`17`	`+`

Comments

(0)