Commit ec7c026

committed

Auto merge of #144863 - cjgillot:live-or-dead, r=Urgau

Simplify dead code lint This PR scratches a few itches I had when looking at that code. The perf improvement comes from keeping the `scanned` set through several marking phases. This pretty much divides by 2 the number of HIR traversals.

2 parents 213d946 + d0da6ca commit ec7c026Copy full SHA for ec7c026

File tree

3 files changed

+199

-274

lines changed

compiler
- rustc_middle/src/query
  - mod.rs
- rustc_passes/src
  - dead.rs
  - lib.rs

3 files changed

+199

-274

lines changed

`‎compiler/rustc_middle/src/query/mod.rs‎`

Lines changed: 2 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -1178,11 +1178,10 @@ rustc_queries! {`
`1178`	`1178`
`1179`	`1179`	`/// Return the live symbols in the crate for dead code check.`
`1180`	`1180`	`///`
`1181`		`- /// The second return value maps from ADTs to ignored derived traits (e.g. Debug and Clone) and`
`1182`		`- /// their respective impl (i.e., part of the derive macro)`
	`1181`	`+ /// The second return value maps from ADTs to ignored derived traits (e.g. Debug and Clone).`
`1183`	`1182`	`query live_symbols_and_ignored_derived_traits(_: ()) -> &'tcx (`
`1184`	`1183`	`LocalDefIdSet,`
`1185`		`- LocalDefIdMap<FxIndexSet<(DefId,DefId)>>`
	`1184`	`+ LocalDefIdMap<FxIndexSet<DefId>>,`
`1186`	`1185`	`) {`
`1187`	`1186`	`arena_cache`
`1188`	`1187`	`desc { "finding live symbols in crate" }`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit ec7c026

File tree

3 files changed

3 files changed

`‎compiler/rustc_middle/src/query/mod.rs‎`

0 commit comments