Commit e18342a

authored

Rollup merge of #143199 - jieyouxu:short-ice, r=RalfJung

Re-disable `tests/run-make/short-ice` on Windows MSVC again We tried to re-enable this for MSVC in #142844. Unfortunately, this test still sometimes fails on Windows MSVC. Tracked in #143198. FYI ```@dpaoliello``` (I couldn't reproduce this easily locally either)

2 parents 7760cd6 + 20d69c6 commit e18342aCopy full SHA for e18342a

File tree

1 file changed

-3

lines changed

tests/run-make/short-ice
- rmake.rs

1 file changed

-3

lines changed

`‎tests/run-make/short-ice/rmake.rs`

Lines changed: 6 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -5,9 +5,12 @@`
`5`	`5`	`// See https://github.com/rust-lang/rust/issues/107910`
`6`	`6`
`7`	`7`	`//@ needs-target-std`
`8`		`-//@ ignore-i686-pc-windows-msvc`
`9`		`-// Reason: the assert_eq! on line 37 fails, almost seems like it missing debug info?`
`10`		`-// Haven't been able to reproduce locally, but it happens on CI.`
	`8`	`+//@ ignore-windows-msvc`
	`9`	`+//`
	`10`	+// - FIXME(#143198): On `i686-pc-windows-msvc`: the assert_eq! on line 37 fails, almost seems like
	`11`	`+// it missing debug info? Haven't been able to reproduce locally, but it happens on CI.`
	`12`	+// - FIXME(#143198): On `x86_64-pc-windows-msvc`: full backtrace sometimes do not contain matching
	`13`	`+// count of short backtrace markers (e.g. 5x end marker, but 3x start marker).`
`11`	`14`
`12`	`15`	`use run_make_support::rustc;`
`13`	`16`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit e18342a

File tree

1 file changed

1 file changed

`‎tests/run-make/short-ice/rmake.rs`

0 commit comments