Commit ced6109

authored

Rollup merge of #142980 - shepmaster:mismatched-syntaxes-multi-suggestions, r=ehuss

Reduce mismatched-lifetime-syntaxes suggestions to MaybeIncorrect `cargo fix` does not have a way of distinguishing a suggestion with multiple spans which should all be applied from multiple suggestions where only one should be applied (see #53934). `cargo fix` only works with `MachineApplicable` suggestions, so downgrading the applicability will stop `cargo` from suggesting the user run `cargo fix`. rust-analyzer does work with `MaybeIncorrect`, so interactive fixes are still available. r? `@ehuss`

2 parents c381635 + 46e9d2f commit ced6109Copy full SHA for ced6109

File tree

1 file changed

-3

lines changed

compiler/rustc_lint/src
- lints.rs

1 file changed

-3

lines changed

`‎compiler/rustc_lint/src/lints.rs‎`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -3278,7 +3278,7 @@ impl Subdiagnostic for MismatchedLifetimeSyntaxesSuggestion {`
`3278`	`3278`	`diag.multipart_suggestion_with_style(`
`3279`	`3279`	`fluent::lint_mismatched_lifetime_syntaxes_suggestion_implicit,`
`3280`	`3280`	`suggestions,`
`3281`		`- Applicability::MachineApplicable,`
	`3281`	`+ Applicability::MaybeIncorrect,`
`3282`	`3282`	`style(tool_only),`
`3283`	`3283`	`);`
`3284`	`3284`	`}`
`@@ -3293,7 +3293,7 @@ impl Subdiagnostic for MismatchedLifetimeSyntaxesSuggestion {`
`3293`	`3293`	`diag.multipart_suggestion_with_style(`
`3294`	`3294`	`fluent::lint_mismatched_lifetime_syntaxes_suggestion_mixed,`
`3295`	`3295`	`suggestions,`
`3296`		`- Applicability::MachineApplicable,`
	`3296`	`+ Applicability::MaybeIncorrect,`
`3297`	`3297`	`style(tool_only),`
`3298`	`3298`	`);`
`3299`	`3299`	`}`
`@@ -3308,7 +3308,7 @@ impl Subdiagnostic for MismatchedLifetimeSyntaxesSuggestion {`
`3308`	`3308`	`diag.multipart_suggestion_with_style(`
`3309`	`3309`	`msg,`
`3310`	`3310`	`suggestions,`
`3311`		`- Applicability::MachineApplicable,`
	`3311`	`+ Applicability::MaybeIncorrect,`
`3312`	`3312`	`style(tool_only),`
`3313`	`3313`	`);`
`3314`	`3314`	`}`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit ced6109

File tree

1 file changed

1 file changed

`‎compiler/rustc_lint/src/lints.rs‎`

0 commit comments