Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Commit 9bd8d17

Browse files
committed
don't uppercase error messages
a more general version of #146080. after a bit of hacking in [`fluent.rs`](https://github.com/rust-lang/rust/blob/master/compiler/rustc_fluent_macro/src/fluent.rs), i discovered that i'm not the only one that is bad at following guidelines 😅. this pr lowercases the first letter of all the error messages in the codebase. (i did not change things that are traditionally uppercased such as _MIR_, _ABI_ or _C_) i think it's reasonable to run a `@bors try` so all the test suite is checked, as i cannot run some of the tests on my machine. i double checked (and replaced manually) all the old error messages, but better be safe than sorry. in the future i will try to add a check in `x test tidy` that errors if an error message starts with an uppercase letter.
1 parent 154037f commit 9bd8d17

File tree

53 files changed

+248
-249
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

53 files changed

+248
-249
lines changed

‎compiler/rustc_attr_parsing/messages.ftl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ attr_parsing_unrecognized_repr_hint =
151151
attr_parsing_unstable_cfg_target_compact =
152152
compact `cfg(target(..))` is experimental and subject to change
153153
154-
attr_parsing_unstable_feature_bound_incompatible_stability = Item annotated with `#[unstable_feature_bound]` should not be stable
154+
attr_parsing_unstable_feature_bound_incompatible_stability = item annotated with `#[unstable_feature_bound]` should not be stable
155155
.help = If this item is meant to be stable, do not use any functions annotated with `#[unstable_feature_bound]`. Otherwise, mark this item as unstable with `#[unstable]`
156156
157157
attr_parsing_unsupported_literal_cfg_boolean =

‎compiler/rustc_codegen_ssa/messages.ftl

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -40,15 +40,15 @@ codegen_ssa_dynamic_linking_with_lto =
4040
.note = only 'staticlib', 'bin', and 'cdylib' outputs are supported with LTO
4141
4242
codegen_ssa_error_calling_dlltool =
43-
Error calling dlltool '{$dlltool_path}': {$error}
43+
error calling dlltool '{$dlltool_path}': {$error}
4444
4545
codegen_ssa_error_creating_import_library =
46-
Error creating import library for {$lib_name}: {$error}
46+
error creating import library for {$lib_name}: {$error}
4747
4848
codegen_ssa_error_creating_remark_dir = failed to create remark directory: {$error}
4949
5050
codegen_ssa_error_writing_def_file =
51-
Error writing .DEF file: {$error}
51+
error writing .DEF file: {$error}
5252
5353
codegen_ssa_expected_name_value_pair = expected name value pair
5454
@@ -264,9 +264,9 @@ codegen_ssa_shuffle_indices_evaluation = could not evaluate shuffle_indices at c
264264
265265
codegen_ssa_specify_libraries_to_link = use the `-l` flag to specify native libraries to link
266266
267-
codegen_ssa_static_library_native_artifacts = Link against the following native artifacts when linking against this static library. The order and any duplication can be significant on some platforms.
267+
codegen_ssa_static_library_native_artifacts = link against the following native artifacts when linking against this static library. The order and any duplication can be significant on some platforms.
268268
269-
codegen_ssa_static_library_native_artifacts_to_file = Native artifacts to link against have been written to {$path}. The order and any duplication can be significant on some platforms.
269+
codegen_ssa_static_library_native_artifacts_to_file = native artifacts to link against have been written to {$path}. The order and any duplication can be significant on some platforms.
270270
271271
codegen_ssa_stripping_debug_info_failed = stripping debug info with `{$util}` failed: {$status}
272272
.note = {$output}
@@ -364,13 +364,13 @@ codegen_ssa_unable_to_run = unable to run `{$util}`: {$error}
364364
365365
codegen_ssa_unable_to_run_dsymutil = unable to run `dsymutil`: {$error}
366366
367-
codegen_ssa_unable_to_write_debugger_visualizer = Unable to write debugger visualizer file `{$path}`: {$error}
367+
codegen_ssa_unable_to_write_debugger_visualizer = unable to write debugger visualizer file `{$path}`: {$error}
368368
369369
codegen_ssa_unexpected_parameter_name = unexpected parameter name
370370
.label = expected `{$prefix_nops}` or `{$entry_nops}`
371371
372372
codegen_ssa_unknown_archive_kind =
373-
Don't know how to build archive of type: {$kind}
373+
don't know how to build archive of type: {$kind}
374374
375375
codegen_ssa_unknown_ctarget_feature =
376376
unknown and unstable feature specified for `-Ctarget-feature`: `{$feature}`

‎compiler/rustc_const_eval/messages.ftl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -457,7 +457,7 @@ const_eval_validation_failure =
457457
it is undefined behavior to use this value
458458
459459
const_eval_validation_failure_note =
460-
The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rustc repository if you believe it should not be considered undefined behavior.
460+
the rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rustc repository if you believe it should not be considered undefined behavior.
461461
462462
const_eval_validation_front_matter_invalid_value = constructing invalid value
463463
const_eval_validation_front_matter_invalid_value_with_path = constructing invalid value at {$path}

‎compiler/rustc_driver_impl/messages.ftl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ driver_impl_ice_version = rustc {$version} running on {$triple}
1414
1515
driver_impl_rlink_corrupt_file = corrupt metadata encountered in `{$file}`
1616
17-
driver_impl_rlink_empty_version_number = The input does not contain version number
17+
driver_impl_rlink_empty_version_number = the input does not contain version number
1818
1919
driver_impl_rlink_encoding_version_mismatch = .rlink file was produced with encoding version `{$version_array}`, but the current version is `{$rlink_version}`
2020
@@ -24,6 +24,6 @@ driver_impl_rlink_rustc_version_mismatch = .rlink file was produced by rustc ver
2424
2525
driver_impl_rlink_unable_to_read = failed to read rlink file: `{$err}`
2626
27-
driver_impl_rlink_wrong_file_type = The input does not look like a .rlink file
27+
driver_impl_rlink_wrong_file_type = the input does not look like a .rlink file
2828
2929
driver_impl_unstable_feature_usage = cannot dump feature usage metrics: {$error}

‎compiler/rustc_parse/messages.ftl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ parse_async_use_order_incorrect = the order of `use` and `async` is incorrect
5858
parse_at_dot_dot_in_struct_pattern = `@ ..` is not supported in struct patterns
5959
.suggestion = bind to each field separately or, if you don't need them, just remove `{$ident} @`
6060
61-
parse_at_in_struct_pattern = Unexpected `@` in struct pattern
61+
parse_at_in_struct_pattern = unexpected `@` in struct pattern
6262
.note = struct patterns use `field: pattern` syntax to bind to fields
6363
.help = consider replacing `new_name @ field_name` with `field_name: new_name` if that is what you intended
6464

‎compiler/rustc_query_system/messages.ftl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ query_system_cycle_usage = cycle used when {$usage}
1818
query_system_increment_compilation = internal compiler error: encountered incremental compilation error with {$dep_node}
1919
.help = This is a known issue with the compiler. Run {$run_cmd} to allow your project to compile
2020
21-
query_system_increment_compilation_note1 = Please follow the instructions below to create a bug report with the provided information
22-
query_system_increment_compilation_note2 = See <https://github.com/rust-lang/rust/issues/84970> for more information
21+
query_system_increment_compilation_note1 = please follow the instructions below to create a bug report with the provided information
22+
query_system_increment_compilation_note2 = see <https://github.com/rust-lang/rust/issues/84970> for more information
2323
2424
query_system_overflow_note = query depth increased by {$depth} when {$desc}
2525

‎src/doc/rustc/src/command-line-arguments/print-options.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ Example:
184184

185185
```bash
186186
$ rustc --print native-static-libs --crate-type staticlib a.rs
187-
note: Link against the following native artifacts when linking against this static library. The order and any duplication can be significant on some platforms.
187+
note: link against the following native artifacts when linking against this static library. The order and any duplication can be significant on some platforms.
188188

189189
note: native-static-libs: -lgcc_s -lutil [REDACTED] -lpthread -lm -ldl -lc
190190
```

‎tests/run-make/separate-link-fail/rmake.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,5 @@ fn main() {
1111
.arg("-Zlink-only")
1212
.input("foo.rs")
1313
.run_fail()
14-
.assert_stderr_contains("The input does not look like a .rlink file");
14+
.assert_stderr_contains("the input does not look like a .rlink file");
1515
}

‎tests/ui/codegen/empty-static-libs-issue-108825.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,4 +15,4 @@ fn panic(_info: &core::panic::PanicInfo) -> ! {
1515
}
1616

1717
//~? NOTE native-static-libs:
18-
//~? NOTE Link against the following native artifacts when linking against this static library
18+
//~? NOTE link against the following native artifacts when linking against this static library

‎tests/ui/const-generics/min_const_generics/invalid-patterns.32bit.stderr

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ error[E0080]: constructing invalid value: encountered 0x42, but expected a boole
1414
LL | get_flag::<{ unsafe { bool_raw.boolean } }, 'z'>();
1515
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ it is undefined behavior to use this value
1616
|
17-
= note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rustc repository if you believe it should not be considered undefined behavior.
17+
= note: the rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rustc repository if you believe it should not be considered undefined behavior.
1818
= note: the raw bytes of the constant (size: 1, align: 1) {
1919
42 │ B
2020
}
@@ -25,7 +25,7 @@ error[E0080]: constructing invalid value: encountered 0x42, but expected a boole
2525
LL | get_flag::<{ unsafe { bool_raw.boolean } }, { unsafe { char_raw.character } }>();
2626
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ it is undefined behavior to use this value
2727
|
28-
= note: The rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rustc repository if you believe it should not be considered undefined behavior.
28+
= note: the rules on what exactly is undefined behavior aren't clear, so this check might be overzealous. Please open an issue on the rustc repository if you believe it should not be considered undefined behavior.
2929
= note: the raw bytes of the constant (size: 1, align: 1) {
3030
42 │ B
3131
}

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /