Commit 8da1a62

authored

Rollup merge of #142877 - yotamofek:pr/rustdoc/comment-eslint-installation-req, r=GuillaumeGomez

Document why tidy checks if `eslint` is installed via `npm` Discussion here: #142851

2 parents 1474a0f + 90524da commit 8da1a62Copy full SHA for 8da1a62

File tree

-0

lines changed

-0

lines changed

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -62,6 +62,9 @@ pub fn check(librustdoc_path: &Path, tools_path: &Path, src_path: &Path, bad: &m`
`62`	`62`	`return;`
`63`	`63`	`}`
`64`	`64`	`};`
	`65`	+ // Having the correct `eslint` version installed via `npm` isn't strictly necessary, since we're invoking it via `npx`,
	`66`	`+ // but this check allows the vast majority that is not working on the rustdoc frontend to avoid the penalty of running`
	`67`	+ // `eslint` in tidy. See also: https://github.com/rust-lang/rust/pull/142851
`65`	`68`	`match get_eslint_version() {`
`66`	`69`	`Some(version) => {`
`67`	`70`	`if version != eslint_version {`

Comments

(0)