-
Notifications
You must be signed in to change notification settings - Fork 13.8k
Commit 73305e2
authored
Rollup merge of #142924 - lolbinarycat:tidy-js-extra-checks, r=Kobzol
tidy: move rustdoc js stuff into a tidy extra check
Most of these were factored out of CI scripts, but `eslint` in particular was previously implemented with its own special cased logic.
A new option has been added to bootstrap, `build.tidy-extra-checks`, which serves as a default value for the `--extra-checks` flag. This is mostly for the benefit of rustdoc js maintainers, but should also help bootstrap py maintainers.
Additionally, `--extra-checks=cpp` has been documented.
I'm not super happy with how long the extra check names are in comparison to the others (in particular `typecheck`), but I couldn't think of anything better (I didn't want to name it `tsc` on the off chance we want to switch to a different typechecking engine in the future).
It would be nice to convert the extra checks arg into a proper enum, both for warning on unknown values and to provide better shell completion.
r? ```@GuillaumeGomez```
Fixes: #144093 File tree
20 files changed
+3434
-142
lines changed- src
- bootstrap/src/core/config
- build_helper/src
- ci/docker/host-x86_64
- pr-check-1
- tidy
- etc/completions
- tools
- rustdoc-gui-test/src
- tidy/src
- ext_tool_checks
20 files changed
+3434
-142
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
85 | 85 | | |
86 | 86 | | |
87 | 87 | | |
88 | - | ||
89 | - | ||
90 | 88 | | |
91 | 89 | | |
92 | 90 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
40 | + | ||
41 | + | ||
40 | 42 | | |
41 | 43 | | |
42 | 44 | | |
| |||
0 commit comments